[felixlaga]

GitHub Enterprise Server validates the whole GraphQL document before applying directives, so pull request lists and linked summaries fail when a query names unsupported stack fields, even with @include(if: false).

This keeps @felixlaga's host-specific query design and author history from #20531, with main merged normally. Enterprise list, search, and summary documents omit stack and stackEntry entirely. github.com keeps stack data in its existing search and summary requests. Shared fragments, alias batching, per-host credentials, paging, and lenient row decoding remain in place.

Verification at 4bdb33d3e1:

• Tests reduced 243 → 242 across two existing files, preserving all 240 baseline cases. Both Enterprise regressions fail with the fix disabled; the listing case reaches repository fallback.
• 281/281 focused cases pass across four files. GitHub/server scoped typechecks, targeted lint/formatting, and generated-query consistency pass.
• Captured generated outbound documents and variables validate against official GHES 3.18 and 3.22 schemas: eight Enterprise passes. Both github.com operations validate against the vendored public schema. The three pre-fix documents fail both Enterprise schemas on the missing stack fields.
• One full independent review round: Claude Opus 5.5 and Codex gpt-6-sol, no findings. Current-head CI is waiting for GitHub fork-workflow approval (CI run); local checks pass.

Before/after proof · Schema validation results

No live Enterprise account was available. An authenticated github.com attempt hit the shared GraphQL rate limit; no live success is claimed. Other Enterprise versions, macOS, Windows, Electron, iOS, and Android were not exercised. No visual layout changed. This fix is limited to stack fields; other schema compatibility work remains separate.

Fixes #20436.

Tests: Codex gpt-6-astra. Implementation: Codex gpt-6.1-sol. Reviews: Claude Opus 5.5 and Codex gpt-6-sol. Harness: T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 0e82bf1

Macroscope's review found this PR approvable — This is a focused GitHub Enterprise compatibility fix that swaps unsupported GraphQL documents for host-specific plain queries while preserving GitHub.com stack behavior. The production logic is limited to pull-request reads, with targeted tests covering the affected paths.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 28cf4408-fa22-4b6e-998f-bf44c68dae84

📥 Commits

Reviewing files that changed from the base of the PR and between 6a71716 and 0e82bf1.

📒 Files selected for processing: 9

• packages/source-control-github/graphql.config.ts
• packages/source-control-github/src/server/GitHubPullRequestApi.test.ts
• packages/source-control-github/src/server/GitHubPullRequestApi.ts
• packages/source-control-github/src/server/gitHubPullRequestJson.test.ts
• packages/source-control-github/src/server/gitHubPullRequestJson.ts
• packages/source-control-github/src/server/pullRequestBatches.graphql
• packages/source-control-github/src/server/pullRequestBatches.graphql.ts
• packages/source-control-github/src/server/pullRequestListings.graphql
• packages/source-control-github/src/server/pullRequestListings.graphql.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The GraphQL documents now separate stack-aware GitHub.com queries from queries used on other hosts. The API routes summary and search requests by host, and the response mapping and tests cover stack membership and Enterprise Server responses.

Changes: Host-specific stack queries

Layer / File(s)	Summary
Separate summary query contracts packages/source-control-github/src/server/pullRequestBatches.graphql, packages/source-control-github/src/server/pullRequestBatches.graphql.ts, packages/source-control-github/graphql.config.ts	Summary fields are shared by regular and stack-aware queries. The regular query omits stack fields, and the stack-aware query is designated for github.com.
Separate listing query contracts packages/source-control-github/src/server/pullRequestListings.graphql, packages/source-control-github/src/server/pullRequestListings.graphql.ts	Regular search and repository-list queries omit stack fields. A dedicated search query and result schema include stack fields.
Host routing, response mapping, and tests packages/source-control-github/src/server/GitHubPullRequestApi.ts, packages/source-control-github/src/server/gitHubPullRequestJson.ts, packages/source-control-github/src/server/GitHubPullRequestApi.test.ts, packages/source-control-github/src/server/gitHubPullRequestJson.test.ts	The API selects stack-aware queries on github.com and regular queries on other hosts. Response decoding and tests cover stack membership and Enterprise Server results.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 0e82b

The host-specific query change is ready to merge after normal checks; no actionable issue was identified.

Security architecture risk: ⚪ Minimal · up to 0e82b

The query split restores Enterprise compatibility while preserving existing host routing, authentication, repository scope, and batching controls. No material security risk was identified in the changed read paths.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The effective exposure remains pull-request reads on the caller-selected host under existing credentials. Restoring Enterprise reads changes availability, but the inspected change does not introduce a new endpoint, privilege grant, mutation, or broader repository authorization.

Trust Boundaries and Controls

• observed — Host-dependent document selection remains behind the existing authentication middleware and request policy. The transport derives its endpoint from the request’s target host, and resolver batch keys include the pinned credential fingerprint and rate-limit scope. Both summary resolvers use the same isolation configuration.

Resilience and Maintainability Implications

• observed — The new stack-aware summary resolver retains the existing batch delay, size limit, and error wrapper. The inspected test definition checks that a not-found alias fails only its own pull request while another result in the same batch remains available.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Issue #20436 requires GHES pull-request lists and linked summaries to load without naming unsupported stack or stackEntry fields. PullRequestSearch and PullRequestList use the plain row fragme…
Out of Scope Changes check		The changes stay within issue #20436. They separate stack-aware GraphQL documents, select documents by host, update generated types, and add focused regression tests and configuration documentation. T…
Title check		The title clearly identifies the fix and its Enterprise Server compatibility scope.
Description check		The description covers the problem, implementation, scope, verification results, limitations, linked issue, and agent details. It does not use the template headings or provide an explicit maintainer a…

Full details: Linked Issues check

Explanation

Issue #20436 requires GHES pull-request lists and linked summaries to load without naming unsupported stack or stackEntry fields. PullRequestSearch and PullRequestList use the plain row fragment. PullRequestSearchWithStacks and PullRequestSummaryWithStacks are selected only for github.com. PullRequestSummary is used for other hosts. The existing stack-membership read remains git.832008.xyz-only. The added tests model GHES schema rejection and cover list, search, and summary behavior. The generated GraphQL files are included.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #20436. They separate stack-aware GraphQL documents, select documents by host, update generated types, and add focused regression tests and configuration documentation. The PR does not change unrelated Enterprise schema fields such as isRequired.

Full details: Description check

Explanation

The description covers the problem, implementation, scope, verification results, limitations, linked issue, and agent details. It does not use the template headings or provide an explicit maintainer approval comment, but the required information is substantially present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[juliusmarminge]

Taking over this one for maintainer integration. I will preserve the author history, reduce the tests to the distinct compatibility behaviors, and verify the generated host-specific queries. No merge from this batch.

[zrm625]

Note

🤖 GPT-6 Astra responding with direction from Zak

This fix is still relevant to current main (33f85846be). I compared the listing and summary .graphql files with c3a36af872, the #19224 commit cited when #20436 was closed: both files are byte-for-byte unchanged and still contain the unsupported stack fields behind @include.

At this PR's current head (4bdb33d3e1), the Enterprise list, search, and summary operations omit those fields, and the caller selects the stack-aware search and summary variants only for github.com. That matches the live GHES verification already reported in the issue.

GitHub currently reports merge conflicts. Could the maintainer integration noted above be resumed, the branch updated against main, and the fix reviewed? I've also replied on #20436 asking for it to be reopened based on the current source.

[juliusmarminge]

Thanks @felixlaga for the earlier work on this GHES regression. This branch is stale: its October 20 head predates changes on main to the same files, and its last conflict check reported conflicts. Closing in favor of #31184 by @mrmeku, which carries the same fix on current main and credits your work.