Skip to content

test(relay): pin delivery attempt retention cutoff #23769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
only21mil wants to merge 5 commits into from
Closed

test(relay): pin delivery attempt retention cutoff #23769

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3beb41
test(relay): pin pruning of old delivery attempts
only21mil Oct 22, 2026
7620b49
fix(relay): prune delivery attempts older than 14 days
only21mil Oct 22, 2026
df9cd3d
Merge remote-tracking branch 'github/main' into maria/takeover-pr-23769
maria-rcks Oct 26, 2026
4ee85d9
fix(relay): index delivery attempt retention cleanup
maria-rcks Oct 26, 2026
0a759d5
fix(relay): reconcile retention cleanup with main
maria-rcks Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions infra/relay/src/agentActivity/DeliveryAttempts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import * as Drizzle from "@alchemy.run/drizzle/Postgres";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as Redacted from "effect/Redacted";
import * as TestClock from "effect/testing/TestClock";
import { PgDialect } from "drizzle-orm/pg-core";
import type { SQL } from "drizzle-orm";

import * as RelayDb from "../db.ts";
import * as DeliveryAttempts from "./DeliveryAttempts.ts";
Expand Down Expand Up @@ -173,10 +176,12 @@ describe("DeliveryAttempts", () => {

const pruneWith = (batches: ReadonlyArray<number>) => {
const deleteCalls: number[] = [];
const predicates: SQL[] = [];
const fakeDb = {
delete: () => ({
where: () => ({
where: (predicate: SQL) => ({
returning: () => {
predicates.push(predicate);
const size = batches[deleteCalls.length] ?? 0;
deleteCalls.push(size);
return Effect.succeed(Array.from({ length: size }, (_, index) => ({ id: `${index}` })));
Expand All @@ -193,15 +198,26 @@ describe("DeliveryAttempts", () => {
),
),
);
return { run, deleteCalls };
return { run, deleteCalls, predicates };
};

it.effect("stops pruning once a batch comes back short", () => {
const full = DeliveryAttempts.DELIVERY_ATTEMPT_PRUNE_BATCH_SIZE;
const { run, deleteCalls } = pruneWith([full, 12]);
const { run, deleteCalls, predicates } = pruneWith([full, 12]);
return Effect.gen(function* () {
yield* TestClock.setTime(Date.parse("2026-05-26T00:00:00.000Z"));
expect(yield* run).toBe(full + 12);
expect(deleteCalls).toEqual([full, 12]);
expect(predicates.map((predicate) => new PgDialect().sqlToQuery(predicate))).toEqual([
{
sql: '"relay_delivery_attempts"."id" in (select "id" from "relay_delivery_attempts" where "relay_delivery_attempts"."created_at" < $1 limit $2)',
params: ["2026-05-19T00:00:00.000Z", full],
},
{
sql: '"relay_delivery_attempts"."id" in (select "id" from "relay_delivery_attempts" where "relay_delivery_attempts"."created_at" < $1 limit $2)',
params: ["2026-05-19T00:00:00.000Z", full],
},
]);
});
});

Expand Down
Loading