Skip to content

fix(shared): Windows-style paths stay out of the slash menu #27851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Nov 12, 2026
+4 −2
Merged

fix(shared): Windows-style paths stay out of the slash menu #27851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f741ff6
fix(shared): Windows-style paths stay out of the slash menu
samkelly880 Oct 30, 2026
333dc0c
Merge remote-tracking branch 'origin/main' into fix/composer-backslas…
juliusmarminge Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/shared/src/composerTrigger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ describe("detectComposerTrigger", () => {
["Run /tmp/build.sh", "Run /tmp/build.sh".length],
["/etc/hosts", "/etc/hosts".length],
["Use /etc/hosts now", "Use /et".length],
["cmd /foo\\bar", "cmd /foo\\bar".length],
["/Windows\\System32", "/Windows\\System32".length],
])("keeps the path in %j out of the slash menu", (text, cursor) => {
expect(detectComposerTrigger(text, cursor)).toBeNull();
});
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/composerTrigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function isWhitespace(char: string): boolean {
return char === " " || char === "\n" || char === "\t" || char === "\r";
}

/** A second slash makes the whole word a path, even when the caret precedes that slash. */
/** A second slash or backslash makes the whole word a path, even when the caret precedes it. */
export function isPathWord(
text: string,
wordStart: number,
Expand All @@ -56,7 +56,7 @@ export function isPathWord(
while (wordEnd < text.length && !isWhitespaceChar(text[wordEnd] ?? "")) {
wordEnd += 1;
}
return text.slice(wordStart + 1, wordEnd).includes("/");
return /[/\\]/.test(text.slice(wordStart + 1, wordEnd));
}

/**
Expand Down
Loading