Skip to content

perf(server): Changes tab loads 11x faster on large reordered files #28073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuruzuu wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −8
Open

perf(server): Changes tab loads 11x faster on large reordered files #28073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions apps/server/src/vcs/GitVcsDriverCore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2975,7 +2975,7 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
}),
);

it.effect("reads Changes totals without minimizing and keeps review diffs minimal", () =>
it.effect("reads Changes totals and review diffs without minimizing", () =>
Effect.gen(function* () {
const cwd = yield* makeTmpDir();
const { initialBranch } = yield* initRepoWithCommit(cwd);
Expand Down Expand Up @@ -3007,10 +3007,8 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
deletions: Number(deletions),
});

const [additions, removals] = minimalStat.split("\t");
const minimalPatch = yield* git(cwd, [
const defaultPatch = yield* git(cwd, [
"diff",
"--minimal",
"--patch",
"--no-color",
"--no-ext-diff",
Expand All @@ -3026,11 +3024,11 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
{
path: "repeated.txt",
previousPath: null,
additions: Number(additions),
deletions: Number(removals),
additions: Number(insertions),
deletions: Number(deletions),
},
]);
assert.strictEqual(source.diff.trim(), minimalPatch);
assert.strictEqual(source.diff.trim(), defaultPatch);
}
}),
);
Expand Down
1 change: 0 additions & 1 deletion apps/server/src/vcs/GitVcsDriverCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3381,7 +3381,6 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*

const diffArgs = [
...REVIEW_DIFF_ARGS,
"--minimal",
...(input.ignoreWhitespace ? ["--ignore-all-space"] : []),
];
const readStats = Effect.fn("GitVcsDriver.getReviewDiffPreview.stat")(function* (
Expand Down
Loading