Skip to content

docs(mobile): Screens fork doc points at each archive's recorded source - #28293

Open
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m029
Open

only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m029

Conversation

@only21mil

@only21mil only21mil commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem

docs/operations/mobile-screens-fork.md links the T3 Screens fork at tag t3-v5.0.0-t3.45. The app now ships react-native-screens-5.0.0-t3.48.tgz (#18492). So the link points at older source than the archive in apps/mobile/deps.

Bumping the link to t3-v5.0.0-t3.48 would 404. pingdotgg/react-native-screens has no t3.46, t3.47 or t3.48 tag. The t3.48 source and tag are on the fork named in that archive's t3-fork.json, as #18492's description links. The t3.45 archive also named a personal fork there, and pingdotgg/react-native-screens now has its t3-v5.0.0-t3.45 tag at the same commit. The link has been bumped by hand each time, once to a personal fork (#24206) and back (#24951).

Change

  • The link goes to the pingdotgg fork itself, with no version pinned.
  • The doc says t3-fork.json also records the source repository.
  • To reproduce an archive, check out the repository and commit that t3-fork.json records.

The doc then stays correct across Screens bumps, and nobody has to edit the link each time.

Scope and approval

This fixes a stale link in a maintainer doc, under the obvious-bug exception. It changes no code. The update steps still say to publish the tag to the fork. The missing t3.46 to t3.48 tags on pingdotgg/react-native-screens are for a maintainer to push. This PR doesn't change that process.

Verification

  • Read package/t3-fork.json from the committed react-native-screens-5.0.0-t3.48.tgz. It records the repository, commit 6ce484b, upstream base and version 5.0.0-t3.48.
  • Listed the tags on pingdotgg/react-native-screens. They stop at t3-v5.0.0-t3.45.
  • vp run check:changed passes (format).

Not checked:

  • No screen changes; this is a maintainer doc.
  • No archive rebuild from the recorded source.

Prior PRs

#18433 by juliusmarminge pointed this doc at the pingdotgg fork, and this keeps that. #18492 by PixPMusic shipped t3.48. I found no open PR that touches this file.

Generated with Claude Opus 5.5 in T3 Code Nightly

The doc linked the pingdotgg fork's t3-v5.0.0-t3.45 tag while the app ships 5.0.0-t3.48, whose source and tag live on the contributor fork named in its t3-fork.json. Link the fork itself and send readers to the repository and commit that t3-fork.json records, so the doc stays true across Screens bumps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 31, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c472824

Macroscope's review found this PR approvable — The documentation now directs archive reproduction to the source repository and commit recorded in each archive instead of a fixed fork tag. No runtime behavior, product defaults, or diagnostic suppressions change.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 15fe283 and c472824.

Files selected for processing: 1
  • docs/operations/mobile-screens-fork.md

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The Mobile Screens fork documentation now links to the repository, describes the source repository in archive metadata, and instructs readers to reproduce from the source repository and commit recorded in t3-fork.json.

Changes: Mobile Screens fork documentation

Layer / File(s) Summary
Archive source and reproduction guidance
docs/operations/mobile-screens-fork.md
The fork link points to the repository. Archive metadata includes the source repository. Reproduction instructions use a clean checkout of the source repository and commit recorded in t3-fork.json.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to c4728

The documentation change has no identified merge-blocking issue.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the documentation change: it points the Screens fork documentation to each archive’s recorded source.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the template's main sections (Problem, Change, Scope and approval, Verification) and fills each one with specific, relevant detail. The Problem section explains the stale fork …
Full details: Description check

Explanation

The description follows the template's main sections (Problem, Change, Scope and approval, Verification) and fills each one with specific, relevant detail. The Problem section explains the stale fork link and why bumping it to t3.48 would 404. The Change section states the link now targets the pingdotgg fork without a pinned version, and that t3-fork.json records the source repository. Scope and approval invokes the obvious-bug exception with a reason, and it notes the maintainer-only tag publishing is out of scope. Verification lists concrete checks (reading t3-fork.json from the shipped archive, listing fork tags, running vp run check:changed) and states what was not checked. The description also gives prior PR context. Minor gaps: the template asks for an agent/model line at the end, and the author included one ("Generated with Claude Opus 5.5 in T3 Code Nightly"), so that is covered. The description does not link a triaged issue, but it argues the obvious-bug exception, which the template permits. The author's model attribution is present. Overall the description is mostly complete and specific.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant