Repository navigation
Conversation
The doc linked the pingdotgg fork's t3-v5.0.0-t3.45 tag while the app ships 5.0.0-t3.48, whose source and tag live on the contributor fork named in its t3-fork.json. Link the fork itself and send readers to the repository and commit that t3-fork.json records, so the doc stays true across Screens bumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The documentation now directs archive reproduction to the source repository and commit recorded in each archive instead of a fixed fork tag. No runtime behavior, product defaults, or diagnostic suppressions change. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Archive source and reproduction guidance docs/operations/mobile-screens-fork.md |
The fork link points to the repository. Archive metadata includes the source repository. Reproduction instructions use a clean checkout of the source repository and commit recorded in t3-fork.json. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- pingdotgg/t3code#24285: Updates the fork link in the same documentation.
- pingdotgg/t3code#26161: Updates the fork link and archive reproduction guidance in the same documentation.
- pingdotgg/t3code#24215: Changes the documented Screens fork link.
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to c4728
-
The documentation change has no identified merge-blocking issue.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description follows the template's main sections (Problem, Change, Scope and approval, Verification) and fills each one with specific, relevant detail. The Problem section explains the stale fork link and why bumping it to t3.48 would 404. The Change section states the link now targets the pingdotgg fork without a pinned version, and that t3-fork.json records the source repository. Scope and approval invokes the obvious-bug exception with a reason, and it notes the maintainer-only tag publishing is out of scope. Verification lists concrete checks (reading t3-fork.json from the shipped archive, listing fork tags, running vp run check:changed) and states what was not checked. The description also gives prior PR context. Minor gaps: the template asks for an agent/model line at the end, and the author included one ("Generated with Claude Opus 5.5 in T3 Code Nightly"), so that is covered. The description does not link a triaged issue, but it argues the obvious-bug exception, which the template permits. The author's model attribution is present. Overall the description is mostly complete and specific.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Problem
docs/operations/mobile-screens-fork.mdlinks the T3 Screens fork at tagt3-v5.0.0-t3.45. The app now shipsreact-native-screens-5.0.0-t3.48.tgz(#18492). So the link points at older source than the archive inapps/mobile/deps.Bumping the link to
t3-v5.0.0-t3.48would 404. pingdotgg/react-native-screens has not3.46,t3.47ort3.48tag. The t3.48 source and tag are on the fork named in that archive'st3-fork.json, as #18492's description links. The t3.45 archive also named a personal fork there, and pingdotgg/react-native-screens now has itst3-v5.0.0-t3.45tag at the same commit. The link has been bumped by hand each time, once to a personal fork (#24206) and back (#24951).Change
t3-fork.jsonalso records the source repository.t3-fork.jsonrecords.The doc then stays correct across Screens bumps, and nobody has to edit the link each time.
Scope and approval
This fixes a stale link in a maintainer doc, under the obvious-bug exception. It changes no code. The update steps still say to publish the tag to the fork. The missing
t3.46tot3.48tags on pingdotgg/react-native-screens are for a maintainer to push. This PR doesn't change that process.Verification
package/t3-fork.jsonfrom the committedreact-native-screens-5.0.0-t3.48.tgz. It records the repository, commit6ce484b, upstream base and version5.0.0-t3.48.t3-v5.0.0-t3.45.vp run check:changedpasses (format).Not checked:
Prior PRs
#18433 by juliusmarminge pointed this doc at the pingdotgg fork, and this keeps that. #18492 by PixPMusic shipped t3.48. I found no open PR that touches this file.
Generated with Claude Opus 5.5 in T3 Code Nightly