Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Windows paths outside the workspace retain their absolute labels rather than receiving a misleading workspace prefix. The change is limited to displayed and copied path text, without changing file targets or stored data. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…outside-workspace-v2
AI-assisted; verified with the tests and tools listed above. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The automated pipeline stopped on this pull request and will not merge it: the fix is written and reviewed, but proving it needs something no worker has:
It stays open for a person to finish or close. |
On Windows, a file outside the project, like an agent editing
C:\Users\me\.claude\settings.json, shows up in the timeline asrepo/C:/Users/me/.claude/settings.json, and "Copy relative path" on a chat file link copies that same string.formatWorkspaceRelativePathonly treated paths starting with/as absolute, so a drive path fell into the relative branch and got the workspace label put in front of it.It now skips the relative branch for Windows absolute paths too, which is what already happens to
/Users/...on macOS. Paths inside the workspace are unchanged.This is a one-line fix for an obvious display bug, so it goes under the small-fix exception in CONTRIBUTING rather than a prior issue.
Replaces https://git.cafe/pingdotgg/t3code/pulls/13414, which was closed for missing captures. The captures were added there on 20 Oct with a reconsideration request; this is the same fix rebuilt on current main, as the closure guide's replacement route.
Verification
Web dev server (
vp run dev) from a worktree at main8b74a69019, Windows 10, isolated.t3state, headless Edge at 1000×640 (2x). One seeded thread whose agent changedC:\Users\demo\.claude\settings.json(outside the project) andsrc\config.ts(inside it). The project root ends inapps\server, so the workspace label isserver. No provider ran.server/C:/Users/demo/.claude/settings.json. Fix:C:/Users/demo/.claude/settings.json. The file inside the project readsserver/src/config.tsin both.vp test run src/filePathDisplay.test.tsinapps/web: with main'sfilePathDisplay.tsthe new case fails (1 failed, 1 passed); with the fix, 2 passed.Not checked: the Electron shell, and mobile, which formats paths with its own helper in
apps/mobile/src/features/files/filePath.tsand is not touched here.Before (main
8b74a69019):After (with this fix):
Model and harness
Claude Opus 5.5 (high effort) in Claude Code, run from T3 Code.
Fixes #27308