Skip to content

fix(mobile): opening a turn diff no longer shows two loading spinners #32656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wSedlacek wants to merge 1 commit into from
+3 −1
Closed

fix(mobile): opening a turn diff no longer shows two loading spinners #32656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/mobile/src/features/review/ReviewSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,8 @@ export function ReviewSheet(props: ReviewSheetProps) {
setIsPullRefreshing(false);
};
const isRefreshing = isPullRefreshing || isSelectedSectionPending || areFilePatchesPending;
// Inline loading already draws the spinner; driving RefreshControl too stacks two circles.
const isInlineDiffLoading = Boolean(selectedSection?.isLoading && selectedSection.diff === null);
// A refresh that starts programmatically adds its height to the native top inset and
// subtracts it when it ends. If topContentInset changes in between, the inset ends up
// short and the content sits under the header, so the fallback ScrollView starts over.
Expand Down Expand Up @@ -710,7 +712,7 @@ export function ReviewSheet(props: ReviewSheetProps) {
refreshControl={
// Fallback and empty states need refresh controls; only Android has an explicit refresh menu.
<RefreshControl
refreshing={isRefreshing}
refreshing={isRefreshing && !isInlineDiffLoading}
onRefresh={() => void handlePullToRefresh()}
/>
}
Expand Down
Loading