Skip to content

fix(mobile): Android chip taps open the chip from either half #33126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 5 commits into from
Nov 9, 2026
+21 −2
Merged

fix(mobile): Android chip taps open the chip from either half #33126

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d114576
fix(mobile): Android chip taps open the chip from either half
maria-rcks Nov 8, 2026
faca193
fix(mobile): Android chip end taps must land on the chip's line
maria-rcks Nov 8, 2026
271e95d
fix(mobile): keep the chip hit test within detekt's return limit
maria-rcks Nov 8, 2026
c81e5f7
fix(mobile): every Android chip tap must land inside the chip
maria-rcks Nov 9, 2026
8819120
fix(mobile): skip stale chip tokens before measuring their bounds
maria-rcks Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions ...mposer-editor/android/src/main/java/expo/modules/t3composereditor/T3ComposerEditorView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ class T3ComposerEditorView(context: Context, appContext: AppContext) : ExpoView(
val token =
tokens.firstOrNull {
(it.type == "context" || it.type == "mention" || it.type == "skill") &&
offset >= it.start &&
offset < it.end
offset in it.start..it.end &&
it.end <= editor.length() &&
chipContains(it, event.x, event.y)
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
Resolved
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
}
?: return false
if (token.end <= editor.length() &&
Expand Down Expand Up @@ -450,6 +451,24 @@ class T3ComposerEditorView(context: Context, appContext: AppContext) : ExpoView(
)
}

// A chip is one replacement span, so a tap on its right half reports the offset at its end,
// and a tap below the last line clamps to it; only the chip's drawn bounds count.
private fun chipContains(token: ComposerToken, viewX: Float, viewY: Float): Boolean {
val layout = editor.layout ?: return false
val x = viewX - editor.totalPaddingLeft + editor.scrollX
val y = viewY - editor.totalPaddingTop + editor.scrollY
val line = layout.getLineForOffset(token.start)
val left = layout.getPrimaryHorizontal(token.start)
val right =
if (layout.getLineForOffset(token.end) == line) {
layout.getPrimaryHorizontal(token.end)
} else {
layout.getLineRight(line)
}
return y >= layout.getLineTop(line) && y <= layout.getLineBottom(line) &&
x >= minOf(left, right) && x <= maxOf(left, right)
}

private fun applyTokenSpans() {
val editable = editor.text ?: return
editable.getSpans(
Expand Down
Loading