Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds right-swipe and accessibility actions to mark eligible mobile threads read or unread. The action uses existing commands, respects operate permissions, and changes only reversible read state. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
The description already states that no prior upstream maintainer approval is claimed and identifies the native recordings as pre-rebase evidence, with native verification not repeated on the rebased head. This is intentionally submitted as a feature for maintainer consideration, not recast as a bug fix. Macroscope has approved approvability at this head: #37448 (comment). That automated approval is not a claim of prior human maintainer approval. No code changes were requested by this review. |
41e1d83 to
2f8329d
Compare
Problem
On a completed mobile thread, swiping right does nothing. Read/unread needs a quick row action alongside the existing left-swipe Settle/Snooze controls.
Change
Swipe right on a completed mobile thread to mark it read or unread. Partial swipes reveal the action; full swipes apply it. Reuses the existing swipe controls and server commands, with accessible row actions and visible failure alerts.
Scope and approval
Requested by the contributor for upstream. Scope is the native mobile thread list, reusing existing server read tracking. No prior upstream maintainer approval is claimed; this is a new gesture for an existing capability.
Verification
Rebased onto upstream main
6234afba12.vp run check:changed 6234afba12passes, including 70 focused tests and React Compiler checks.On an iPhone 17 simulator (iOS 26.4), verified both toggles, full swipes, persistence after relaunch, Settle/Snooze, and disconnected-server errors against an isolated backend with synthetic threads. Recordings below are from
0e90b82ae4, before the upstream rebase; native verification has not been repeated on the rebased head.Before recording · After recording · Failure recording
Android, physical haptics, and audible screen-reader behavior remain unverified. Sol reviewed; both findings were fixed.
Built with GPT-6.1 Sol through Codex in T3 Code.