Skip to content

feat(mobile): swipe right to mark threads read or unread - #37448

Open
Cujuju wants to merge 2 commits into
pingdotgg:mainfrom
Cujuju:feat/mobile-right-swipe-read-upstream
Open

Cujuju wants to merge 2 commits into
pingdotgg:mainfrom
Cujuju:feat/mobile-right-swipe-read-upstream

Conversation

@Cujuju

@Cujuju Cujuju commented Nov 16, 2026 •

Copy link
Copy Markdown

Problem

On a completed mobile thread, swiping right does nothing. Read/unread needs a quick row action alongside the existing left-swipe Settle/Snooze controls.

Change

Swipe right on a completed mobile thread to mark it read or unread. Partial swipes reveal the action; full swipes apply it. Reuses the existing swipe controls and server commands, with accessible row actions and visible failure alerts.

Scope and approval

Requested by the contributor for upstream. Scope is the native mobile thread list, reusing existing server read tracking. No prior upstream maintainer approval is claimed; this is a new gesture for an existing capability.

Verification

Rebased onto upstream main 6234afba12. vp run check:changed 6234afba12 passes, including 70 focused tests and React Compiler checks.

On an iPhone 17 simulator (iOS 26.4), verified both toggles, full swipes, persistence after relaunch, Settle/Snooze, and disconnected-server errors against an isolated backend with synthetic threads. Recordings below are from 0e90b82ae4, before the upstream rebase; native verification has not been repeated on the rebased head.

Before recording · After recording · Failure recording

Before After
Right swipe does nothing Right swipe reveals Read

Android, physical haptics, and audible screen-reader behavior remain unverified. Sol reviewed; both findings were fixed.

Built with GPT-6.1 Sol through Codex in T3 Code.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Nov 16, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 41e1d83

Macroscope's review found this PR approvable — Adds right-swipe and accessibility actions to mark eligible mobile threads read or unread. The action uses existing commands, respects operate permissions, and changes only reversible read state.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Thread rows now support marking eligible completed threads read or unread through right swipes and accessibility actions. The swipe component renders and animates actions in either direction, while existing left-swipe behavior remains.

Changes: Thread read-state actions

Layer / File(s) Summary
Read-action eligibility
apps/mobile/src/features/threads/threadListV2.ts, apps/mobile/src/features/threads/threadListV2.test.ts
resolveThreadListV2ReadAction selects read or unread for eligible completed threads. Tests cover eligible states and conditions that return null.
Right-swipe action support
apps/mobile/src/features/home/thread-swipe-actions.tsx
ThreadSwipeable accepts an optional right-swipe action and handles releases in either direction. Action rendering and animations use the configured direction.
Thread-row read-state actions
apps/mobile/src/features/threads/thread-list-v2-items.tsx
Card and slim rows provide the conditional read-state action through swipes and accessibility actions. The row handler calls visit or markUnread, and swipe hints describe the available action.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant ThreadSwipeable
  participant ThreadListV2Row
  participant ThreadOperation
  User->>ThreadSwipeable: Swipe right and release
  ThreadSwipeable->>ThreadListV2Row: Commit configured read-state action
  ThreadListV2Row->>ThreadOperation: Call visit or markUnread
Loading

Possibly related PRs

  • pingdotgg/t3code#29712: Adds right-swipe actions to mobile thread rows, which overlap with this change’s swipe behavior.
  • pingdotgg/t3code#21760: Makes right-swipe thread-row actions configurable and assigns Snooze by default, which may need reconciliation with the read/unread action.

Suggested reviewers: juliusmarminge, t3dotgg, maria-rcks

Merge Risk: Minimal · up to 2f832

This adds right-swipe and accessibility actions to mark completed threads read or unread, reusing existing server commands and permission checks. No concrete defect remains. The author did not repeat native verification on the rebased head, and Android and screen-reader behavior are untested.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: a right swipe on mobile threads that marks them read or unread. It uses the conventional commit form and matches the raw summary and objectives. It is specific and con…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the repository template and covers Problem, Change, Scope, and Verification. It states the problem (a completed mobile thread does not respond to a right swipe) and the change …
Full details: Title check

Explanation

The title names the main change: a right swipe on mobile threads that marks them read or unread. It uses the conventional commit form and matches the raw summary and objectives. It is specific and concise.

Full details: Description check

Explanation

The description follows the repository template and covers Problem, Change, Scope, and Verification. It states the problem (a completed mobile thread does not respond to a right swipe) and the change (right swipe toggles read/unread with partial and full swipe behavior). Scope says the change is a new gesture, not a bug fix, and that no prior maintainer approval is claimed. The template requires a bug fix, and the Scope section admits this is a feature. The Verification section gives concrete checks on an iPhone 17 simulator and names unverified areas. It does not identify a linked issue, and the native checks predate the rebase onto upstream main. The template also asks for before/after screenshots for UI changes. The PR includes them, but they are hosted on a personal fork release and were captured before the rebase. The description has a 'Built with' attribution line that the template asks for when an agent was used, and it names the model.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 41e1d83 and 2f8329d.

Files selected for processing: 1

  • apps/mobile/src/features/threads/thread-list-v2-items.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@Cujuju

Cujuju commented Nov 16, 2026

Copy link
Copy Markdown
Author

The description already states that no prior upstream maintainer approval is claimed and identifies the native recordings as pre-rebase evidence, with native verification not repeated on the rebased head. This is intentionally submitted as a feature for maintainer consideration, not recast as a bug fix. Macroscope has approved approvability at this head: #37448 (comment). That automated approval is not a claim of prior human maintainer approval. No code changes were requested by this review.

@Cujuju
Cujuju force-pushed the feat/mobile-right-swipe-read-upstream branch from 41e1d83 to 2f8329d Compare November 16, 2026 03:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant