Repository navigation
Conversation
A published environment theme without canvas and accent seeds filled every role it left out from the T3 Chat palette, so a partial palette (one role plus some CSS, say) repainted the whole app in T3 Chat's purples. The same happened to the other-appearance variant of any published theme. Missing roles now come from the stock T3 Code palette that clients paint with no theme. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Published themes with unspecified colors will now inherit the stock web palette instead of the T3 Chat palette. Human review is required to confirm this change to default visual behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Problem
A published environment theme without
canvasandaccentseeds fills every color role it leaves out fromgetDefaultThemeColors, which is the T3 Chat palette. So a partial palette, such as one role plus somecss, repaints the whole app in T3 Chat's purples instead of keeping the stock T3 Code look. The other-appearance variant of any published theme has the same problem.I hit this with the agent theme tool: asking an agent for a small CSS tweak (colored pinned threads) washed out the whole app. The agent had to copy all 61 stock roles into the theme to keep the normal look.
Change
publishedThemeColorsnow starts fromgetStandardPaintedThemeColors(appearance), the palette clients paint when no theme is selected. Seeded themes in their own appearance still use the generated palette. Stored custom themes and theme-file import still fall back to T3 Chat, asthemePalette.test.tsexpects; this PR leaves that boundary alone.Testing
keeps seeds, partial palettes, and usable alternate appearancesinuseEnvironmentTheme.test.tsto assert that omitted roles match the stock palette for a partial dark theme and for a light variant. It fails on main (canvasisoklch(0.22813 0.020366 307.469), expected#000000) and passes here.vp run check:changedpassed: format, lint, knip, typecheck, the tests beside the change, and the React compiler check.searchMatchBackgroundplus one CSS rule, rant3 theme set, and captured the web client on main and on this branch.Before (main):
After:
Not exercised: the desktop shell (it renders the same web palette) and light mode in a real client (covered by the light-variant assertion). Mobile does not use environment themes.
Risk
Low. Display only. A published theme that relied on the T3 Chat fallback for roles it omitted will now show stock colors for those roles instead. Themes seeded with
canvasandaccentare unchanged in their own appearance.How to revert
Revert this commit. Partial published themes go back to filling omitted roles from the T3 Chat palette.
Reviewed-by: fresh-context Codex review (GPT-6.1 Sol), approved; its two nits (exact override values in the test, narrower trigger wording) are applied.
Implemented by Claude (Opus 5.5, Claude Code).
🤖 Generated with Claude Code