Open
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (69.23%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
- Coverage 82.44% 82.31% -0.14%
==========================================
Files 121 123 +2
Lines 6928 7005 +77
==========================================
+ Hits 5712 5766 +54
- Misses 805 819 +14
- Partials 411 420 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c26fc58 to
8043e6f
Compare
8043e6f to
ec6817e
Compare
theodorsm
commented
Apr 13, 2026
| } | ||
|
|
||
| h.ContentType = protocol.ContentType(data[0]) | ||
| if protocol.IsDTLS13Ciphertext(h.ContentType) { |
Member
Author
There was a problem hiding this comment.
Hmm, we should also check if we have enabled DTLS 1.3 before parsing and returning something that would be unvalid for DTLS 1.2. Tied to TODOs in #738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the new DTLS 1.3 Unified Header that is part of the new record layer encoding.
https://datatracker.ietf.org/doc/html/rfc9147#name-the-dtls-record-layer:
Reference issue
Partly fixes #755