Fix not sending MasterKeyIdentifier in the use_srtp extension#835
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dtls-1.2 #835 +/- ##
============================================
+ Coverage 82.44% 82.46% +0.01%
============================================
Files 121 121
Lines 6928 6929 +1
============================================
+ Hits 5712 5714 +2
+ Misses 805 804 -1
Partials 411 411
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
May 17, 2026
Member
JoTurk
left a comment
There was a problem hiding this comment.
Thank you, Will be cool to have a regression test.
Member
Author
|
@JoTurk thanks for the quick review. We are lacking proper tests for flights currently. I want to improve that together with the new flights for dtls 1.3. I'll add this as a regressions test if I make such a PR in the future, I suspect there are more subtle bugs hiding around too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
use_srtpextension is missing the configuredMasterKeyIdentifierin flight 3 (the second ClientHello after a HelloVerifyRequest)Also updated the comment above
UseSRTPto point to the correct RFC.