Skip to content

Fix not sending MasterKeyIdentifier in the use_srtp extension#835

Merged
theodorsm merged 1 commit into
dtls-1.2from
fix_srtp_mki
May 17, 2026
Merged

Fix not sending MasterKeyIdentifier in the use_srtp extension#835
theodorsm merged 1 commit into
dtls-1.2from
fix_srtp_mki

Conversation

@theodorsm
Copy link
Copy Markdown
Member

Description

Currently, the use_srtp extension is missing the configured MasterKeyIdentifier in flight 3 (the second ClientHello after a HelloVerifyRequest)

Also updated the comment above UseSRTP to point to the correct RFC.

@theodorsm theodorsm changed the title Fix not sending the MasterKeyIdentifier in the use_srtp extension Fix not sending MasterKeyIdentifier in the use_srtp extension May 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.46%. Comparing base (fd27a52) to head (e6957b0).

Additional details and impacted files
@@             Coverage Diff              @@
##           dtls-1.2     #835      +/-   ##
============================================
+ Coverage     82.44%   82.46%   +0.01%     
============================================
  Files           121      121              
  Lines          6928     6929       +1     
============================================
+ Hits           5712     5714       +2     
+ Misses          805      804       -1     
  Partials        411      411              
Flag Coverage Δ
go 82.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theodorsm theodorsm changed the base branch from main to dtls-1.2 May 16, 2026 22:51
Copy link
Copy Markdown
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Will be cool to have a regression test.

@theodorsm
Copy link
Copy Markdown
Member Author

@JoTurk thanks for the quick review. We are lacking proper tests for flights currently. I want to improve that together with the new flights for dtls 1.3. I'll add this as a regressions test if I make such a PR in the future, I suspect there are more subtle bugs hiding around too.

@theodorsm theodorsm merged commit e4b257d into dtls-1.2 May 17, 2026
17 checks passed
@theodorsm theodorsm deleted the fix_srtp_mki branch May 17, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants