bug(cloudrun): fix parseContainerImage to handle images with registry…#6572
Open
zyzzmohit wants to merge 2 commits intopipe-cd:masterfrom
Open
bug(cloudrun): fix parseContainerImage to handle images with registry…#6572zyzzmohit wants to merge 2 commits intopipe-cd:masterfrom
zyzzmohit wants to merge 2 commits intopipe-cd:masterfrom
Conversation
… ports Signed-off-by: zyzzmohit <mohitray949@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR addresses a parsing issue within pkg/app/piped/platformprovider/cloudrun/servicemanifest.go. The previous implementation of parseContainerImage naively split the image URI by
:to find the tag, which broke when a service manifest utilized an image from a custom Docker registry containing a port (e.g.,localhost:5000/image:tag).The new implementation isolates the last segment of the URI path and correctly searches for the tag's delimiter strictly using
strings.LastIndex.I have also added multiple dedicated unit test cases in servicemanifest_test.go for both FindImageTag and FindArtifactVersions to guarantee this behavior.
Why we need it:
Cloud Run services referencing images using custom registry ports will now correctly deploy without parsing errors during the repository artifact retrieval phase.
Which issue(s) this PR fixes:
Fixes #6571
Does this PR introduce a user-facing change?: