Skip to content

Allows training if model is not modified by "_minimize_model". Adds deprecation warning. #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmylk merged 4 commits into from
Mar 12, 2017
Merged

Allows training if model is not modified by "_minimize_model". Adds deprecation warning. #1207

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11ad64d
checks if model changed before setting model_trimmed_post_training
chinmayapancholi13 Mar 12, 2017
2a3c192
shows deprecation warning for _minimize_model
chinmayapancholi13 Mar 12, 2017
4091d3e
using warnings.warn to show deprecation message
chinmayapancholi13 Mar 12, 2017
0be6395
updated warning message and logic to check parameters
chinmayapancholi13 Mar 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gensim/models/word2vec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
from collections import defaultdict
import threading
import itertools
import warnings

from gensim.utils import keep_vocab_item, call_on_class_only
from gensim.utils import keep_vocab_item
Expand Down Expand Up @@ -1245,6 +1246,9 @@ def __str__(self):
return "%s(vocab=%s, size=%s, alpha=%s)" % (self.__class__.__name__, len(self.wv.index2word), self.vector_size, self.alpha)

def _minimize_model(self, save_syn1 = False, save_syn1neg = False, save_syn0_lockf = False):
warnings.warn("This method would be deprecated in the future. Keep just_word_vectors = model.wv to retain just the KeyedVectors instance for read-only querying of word vectors.")
if save_syn1 and save_syn1neg and save_syn0_lockf:
return
if hasattr(self, 'syn1') and not save_syn1:
del self.syn1
if hasattr(self, 'syn1neg') and not save_syn1neg:
Expand Down