Skip to content

Store images from README directly in repository. Fix #1849#1861

Merged
menshikh-iv merged 3 commits into
piskvorky:developfrom
ibrahimsharaf:readme_images
Feb 6, 2018
Merged

Store images from README directly in repository. Fix #1849#1861
menshikh-iv merged 3 commits into
piskvorky:developfrom
ibrahimsharaf:readme_images

Conversation

@ibrahimsharaf
Copy link
Copy Markdown
Contributor

Issue (#1849)

@menshikh-iv
Copy link
Copy Markdown
Contributor

menshikh-iv commented Jan 29, 2018

Thank you @ibrahimsharaf, can you make it bigger (same size as https://github.com/RaRe-Technologies/gensim#adopters, width=100)?

@menshikh-iv menshikh-iv changed the title Store images from README directly in repository Store images from README directly in repository. Fix #1849 Jan 29, 2018
@ibrahimsharaf
Copy link
Copy Markdown
Contributor Author

Hi @menshikh-iv, I already made them all width=100, should I make it 200?

@menshikh-iv
Copy link
Copy Markdown
Contributor

menshikh-iv commented Jan 29, 2018

@ibrahimsharaf I see two problems:

  • Look at the rendered version of README.md, this doesn't look like width=100 (you can check it with "devtools" of your browser), README should look like current readme.
  • You have distorted the proportions of some of the logos, need to stay original proportions.

@menshikh-iv
Copy link
Copy Markdown
Contributor

Ping @ibrahimsharaf, how is going?

@ibrahimsharaf
Copy link
Copy Markdown
Contributor Author

Hi @menshikh-iv, I've been busy recently, will continue work on the PR by tomorrow.

@ibrahimsharaf
Copy link
Copy Markdown
Contributor Author

Hi @menshikh-iv, would you take a look?

@menshikh-iv
Copy link
Copy Markdown
Contributor

Hi @ibrahimsharaf, thanks, good work:+1:

@menshikh-iv menshikh-iv merged commit caed7d0 into piskvorky:develop Feb 6, 2018
@ibrahimsharaf ibrahimsharaf deleted the readme_images branch February 6, 2018 14:20
sj29-innovate pushed a commit to sj29-innovate/gensim that referenced this pull request Feb 21, 2018
 (piskvorky#1861)

* Add README images to repo

* Resize images

* Bigger images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants