Fix WordEmbeddingsKeyedVectors.most_similar#2461
Merged
Merged
Conversation
mpenkov
reviewed
Apr 28, 2019
mpenkov
reviewed
Apr 28, 2019
mpenkov
reviewed
Apr 28, 2019
mpenkov
reviewed
Apr 28, 2019
Collaborator
mpenkov
left a comment
mpenkov
left a comment
There was a problem hiding this comment.
Thank you for this PR.
I notice this PR fixes a bug. I think it would be helpful to introduce a unit test that reproduces the bug (fails on old code) and passes on new code. This will:
- Objectively confirm that the bug has been fixed
- Prevent future regressions of the same bug
What do you think? Is it possible to test this new fix?
Contributor
Author
mpenkov
approved these changes
May 4, 2019
Collaborator
mpenkov
left a comment
mpenkov
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for your contribution.
This was referenced May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues #2356 in reaction to #2455. The PR accomplishes the following:
most_similar(…, topn=x), wherebool(x)isFalse.most_similar(…, topn=None).topn=Noneinmost_similar_cosmul,similar_by_word, andsimilar_by_vector.indexerinmost_similarwhentopnisNone, since indexers don't supporttopn=None.