Skip to content

feat!: create result.values with null prototype #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcoe merged 9 commits into from
Apr 17, 2022
Merged

feat!: create result.values with null prototype #111

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
85c9325
create result.values with null prototype
shadowspawn Apr 15, 2022
aaca554
Fix where applying null prototype
shadowspawn Apr 15, 2022
1b4b853
Tests churn
shadowspawn Apr 16, 2022
bb4b917
Remove test for unimplemented feature
shadowspawn Apr 16, 2022
bdba1fc
Merge branch 'main' into feature/values-null-prototype
shadowspawn Apr 16, 2022
e0e3a3d
Add __proto__ in new test after merge
shadowspawn Apr 16, 2022
f49f7e5
Simple values access now has null prototype
shadowspawn Apr 16, 2022
7095573
Use same style as other tests for __proto__ test
shadowspawn Apr 16, 2022
eea794e
Merge remote-tracking branch 'upstream/main' into feature/values-null…
shadowspawn Apr 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ const parseArgs = ({
);

const result = {
values: {},
values: { __proto__: null },
positionals: []
};

Expand Down
14 changes: 14 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,3 +378,17 @@ test('invalid short option length', () => {
code: 'ERR_INVALID_ARG_VALUE'
});
});

test('null prototype: when no options then values.toString is undefined', () => {
const result = parseArgs({ args: [] });
assert.strictEqual(result.values.toString, undefined);
});

test('null prototype: when --toString then values.toString is true', () => {
const args = ['--toString'];
const options = { toString: { type: 'boolean' } };
const expectedResult = { values: { __proto__: null, toString: true }, positionals: [] };

const result = parseArgs({ args, options });
assert.deepStrictEqual(result, expectedResult);
});