pkp/immersion#127 Cover image has neither an accessible name nor is marked as decorative or redundant#162
Open
israelcefrin wants to merge 1 commit intopkp:mainfrom
Open
Conversation
israelcefrin
moved this from In progress
to Ready for review/testing
in Accessibility (themes)
Member
|
Hi @israelcefrin, finally coming back to reviewing these PRs, thanks for waiting! For this, could the approach used in the default theme work here too, e.g.: https://github.com/pkp/ojs/blob/7865ba336fd0423ea8b7fe2ebb40a6ba2e118365/templates/frontend/objects/issue_toc.tpl#L41-L50 I ask because it makes it easier to maintain the themes when the code is similar across them. It looks like the archive page also loads the cover image with no alt text, so that template also needs a look but could be done in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kaitlinnewson
Fixing the ALT text missing and implementing an
aria-labelto the link to the full issue.Issue: #127