Conversation
Owner
|
I am willing to accept this change, but can you please add appropriate tests? Thanks. |
Contributor
Author
|
I've added more tests, i also renamed the tests for clarity since there are more cases to consider. |
Owner
|
Looks good, just minor issues:
assert!(err.contains("error: the workspace already contains a package with this name")); |
Contributor
Author
|
Thanks for the feedback, I've made the changes. |
pksunkara
approved these changes
Dec 3, 2025
80a0d39 to
a25d8d4
Compare
Owner
|
Thanks for the high-quality PR. Really appreciate it. 🫰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each time the init command is run on an already existing workspace the workspace(explicit as
"") is added to theCargo.tomleach time, causing errors, this change makes a re-init to be a no-op.Note: In the case where new packages were added to the workspace since it was initially initialized, if the new packages reflect in the
Cargo.tomlthen the only thing that happens is what is described above, in the case where it doesn't, the init command fails with acargo-metadataerror, so except for the change described above the init command stays the same.