fix stack overflow in when accidentally following non-workspace deps that shadow workspace dep names#211
Merged
pksunkara merged 3 commits intopksunkara:masterfrom Jan 17, 2026
Conversation
Owner
|
Really appreciate the PR. Since I had recently updated the MSRV, I want to do a little bit more work before next release. Please let me know if you need a quick release though and I can backport this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue when publishing the dioxus repo.
We're shadowing our own crate for backwards compatibility, but cargo-workspaces chokes on this and ends up self-recursing into a stack overflow.
This fixes that by only inserting dag members that have a path on the filesystem (are not published crates)