Skip to content

Comments

fix stack overflow in when accidentally following non-workspace deps that shadow workspace dep names#211

Merged
pksunkara merged 3 commits intopksunkara:masterfrom
jkelleyrtp:jk/fix-stack-overflow
Jan 17, 2026
Merged

fix stack overflow in when accidentally following non-workspace deps that shadow workspace dep names#211
pksunkara merged 3 commits intopksunkara:masterfrom
jkelleyrtp:jk/fix-stack-overflow

Conversation

@jkelleyrtp
Copy link
Contributor

@jkelleyrtp jkelleyrtp commented Jan 17, 2026

I had an issue when publishing the dioxus repo.

We're shadowing our own crate for backwards compatibility, but cargo-workspaces chokes on this and ends up self-recursing into a stack overflow.

This fixes that by only inserting dag members that have a path on the filesystem (are not published crates)

[package]
name = "const-serialize"
version = "0.8.0-alpha.0"
authors = ["Evan Almloff"]
edition = "2021"
description = "A serialization framework that works in const contexts"
license = "MIT OR Apache-2.0"
repository = "https://github.com/dioxuslabs/dioxus"
homepage = "https://dioxuslabs.com/learn/0.5/getting_started"
keywords = ["const", "serialize"]
rust-version = "1.83.0"

[dependencies]
const-serialize-macro = { workspace = true }
serde = { workspace = true, features = ["derive"], optional = true }
const-serialize-07 = { package = "const-serialize", version = "=0.7.2", optional = true }

@jkelleyrtp jkelleyrtp changed the title jk/fix stack overflow fix stack overflow in when accidentally following non-workspace deps that shadow workspace dep names Jan 17, 2026
@pksunkara pksunkara merged commit 4165711 into pksunkara:master Jan 17, 2026
10 checks passed
@pksunkara
Copy link
Owner

Really appreciate the PR. Since I had recently updated the MSRV, I want to do a little bit more work before next release. Please let me know if you need a quick release though and I can backport this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants