Closed
Conversation
Collaborator
Author
|
We've decided to stick to turbo modules for now as faster app initialization outweighs the easier integration (especially on the longer term) In the future we may decide to revise this or to add auto linking support for Turbo Modules. (when that becomes possible) |
|
are you sure that it's not autolinking now? Because if I add it to MainApplication.java, I get an error saying it has already been linked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigate a community request to support autolinking on Android: #299
It seems like react native supports two kind of Android modules: Native Modules and Turbo Modules (still in development).
As the name implies, Turbo modules are faster to initialize which speeds up cold start of react native apps. However they are still under development, even though already introduced since react native 0.60.0.
While I couldn't find a conclusive answer on this, it seems like Turbo Modules don't support autolinking (yet?). So this means we have to make a choice between either:
This PR follows the steps to create a Native Module and makes autolinking work for our react native SDK.
We're looking for community feedback/guidance on how to proceed on this.
Note: interestingly, Lottie react native uses the Native Module