Skip to content

Comments

Fix some warnings#1274

Merged
mplorentz merged 5 commits intoplanetary-social:mainfrom
RomanPodymov:main
Jul 24, 2024
Merged

Fix some warnings#1274
mplorentz merged 5 commits intoplanetary-social:mainfrom
RomanPodymov:main

Conversation

@RomanPodymov
Copy link
Contributor

Hello.
Thank you for planetary-ios.
Fix some warnings.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@mplorentz mplorentz self-requested a review November 14, 2023 15:11
@RomanPodymov
Copy link
Contributor Author

Hello @mplorentz
I see tests are failing, but they are failing for all pull requests. Or should I also fix it?

Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RomanPodymov, thanks so much for the contribution. I'm sorry it's take so long to get back to you, we aren't working much on Planetary anymore.

I think you can ignore the test failures for these tests:

FeedStrategyTests.testPostsAlgorithm()
FeedStrategyTests.testPostsAndContactsAlgorithm()
FeedStrategyTests.testRecentlyActivePostsAndContactsAlgorithm()

They are also failing on main. However I am worried about this failing test:

AppConfigurationTests.test_archiving()

As that one has not failed on main, and I suspect it may be related to the changes to AppConfiguration+Data.swift. If you could take a look into that I would appreciate it. Otherwise I will look into it when I get time.

 into planetary-social-main

# Conflicts:
#	Source/Controller/ThreadViewController.swift
@mplorentz mplorentz self-requested a review July 18, 2024 21:14
@RomanPodymov
Copy link
Contributor Author

Hello @mplorentz
Fixed AppConfigurationTests.test_archiving.

@mplorentz mplorentz added the Skip-Changelog Signals the Check Changelog CI job that it doesn't need to check this PR. label Jul 24, 2024
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @RomanPodymov!

@mplorentz mplorentz merged commit 45e5f08 into planetary-social:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog Signals the Check Changelog CI job that it doesn't need to check this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants