Conversation
aaronschweig
requested changes
Jan 9, 2026
Contributor
aaronschweig
left a comment
aaronschweig
left a comment
There was a problem hiding this comment.
Small comments and one additional ask:
please make sure to also remove the enum validation in the account_types and regenerate the crds and apiresourceschemas
Contributor
Author
|
(mistakenly undrafted ) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…t special) On-behalf-of: @SAP <simon@simontesar.com>
Contributor
Author
|
I haven't been able to actually test it because of local-setup woes, but this change adds support to the helm chart: platform-mesh/helm-charts@5fb32a6 |
aaronschweig
approved these changes
Jan 14, 2026
Contributor
aaronschweig
left a comment
aaronschweig
left a comment
There was a problem hiding this comment.
LGTM - lets make sure we have the follow up changes prepared in the helm-charts and the platform-mesh operator
On-behalf-of: @SAP <simon@simontesar.com>
- Update APIExport schema reference to use correct version - Fix test expectation for workspace type naming Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
- Add core.platform-mesh.io/org label to org and account workspace types - Rename subroutine constants to shorter names Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
nexus49
added a commit
to platform-mesh/security-operator
that referenced
this pull request
Feb 6, 2026
Replace hardcoded workspace type name matching (-org, -acc suffixes) with label-based selection using core.platform-mesh.io/org label. This makes the workspace authorization more flexible and able to handle any number of workspace types per organization. Depends on: platform-mesh/account-operator#118 Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
nexus49
added a commit
to platform-mesh/security-operator
that referenced
this pull request
Feb 6, 2026
Replace hardcoded workspace type name matching (-org, -acc suffixes) with label-based selection using core.platform-mesh.io/org label. This makes the workspace authorization more flexible and able to handle any number of workspace types per organization. Depends on: platform-mesh/account-operator#118 Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
nexus49
added a commit
to platform-mesh/security-operator
that referenced
this pull request
Feb 9, 2026
Replace hardcoded workspace type name matching (-org, -acc suffixes) with label-based selection using core.platform-mesh.io/org label. This makes the workspace authorization more flexible and able to handle any number of workspace types per organization. Depends on: platform-mesh/account-operator#118 Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
nexus49
added a commit
to platform-mesh/security-operator
that referenced
this pull request
Feb 9, 2026
Replace hardcoded workspace type name matching (-org, -acc suffixes) with label-based selection using core.platform-mesh.io/org label. This makes the workspace authorization more flexible and able to handle any number of workspace types per organization. Depends on: platform-mesh/account-operator#118 On-behalf-of: @SAP <bastian.echterhoelter@sap.com> Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.