Add ThingPulse ePulse Feather and ePulse Feather C6 board definition

[squix78]

Both boards are already on the arduino-esp32 repository:

• https://github.com/espressif/arduino-esp32/blob/master/variants/thingpulse_epulse_feather/pins_arduino.h
• https://github.com/espressif/arduino-esp32/blob/master/variants/thingpulse_epulse_feather_c6/pins_arduino.h

Source:

• https://thingpulse.com/product/epulse-feather-low-power-esp32-development-board/
• https://thingpulse.com/product/epulse-feather-low-power-esp32-c6/

[valeros]

Shouldn't it be -DARDUINO_THINGPULSE_EPULSE_FEATHER?

[squix78]

Fixed it

[valeros]

Looks like a typo, should be thingpulse_epulse_feather.

[squix78]

Good catch! Thank you

[valeros]

Where are the extra_flags and ldscript entries for Arduino framework?

[squix78]

I added extra_flags, but the only example I have for esp32-c6 is the espressif modules and they don't have the ldscript value set

[valeros]

Probably bluetooth is missing.

[squix78]

I added zigbee and thread as well.

[valeros]

Hi @squix78, thanks for the PR, it will be merged when a new stable release of Arduino core is published. Meanwhile, please address my comments above.

[squix78]

Hi @valeros
Do you feel that I completely addressed your comments? Is the dependency to the arduino framework stable release because I added arduino to supported platforms? I can also remove that now and do another PR once arduino stable is released...

[valeros]

Is the dependency to the arduino framework stable release because I added arduino to supported platforms?

That's right, if IDF is enough, you can remove Arduino from the list of supported frameworks.

[Jason2866]

@valeros ldscript entries for Arduino are not used since core 2.0.0. Can be removed from all board manifest. The usual copy & paste -> it was always there ;-)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.