Add board ESP32-S3 PowerFeather#1344
Conversation
|
Hi @Jason2866 thank you for the input, as I am unfamiliar with adding new board support for PlatformIO. Is there a guide somewhere (also for adding support for a library: https://github.com/PowerFeather/powerfeather-sdk)? |
|
@powerfeatherdev Just add a library.json and/or library.properties in the repo and it can be used as lib with Platformio. |
|
@Jason2866 For the If so, my library already has one when I added Arduino support - but in that case I had to submit it to the Arduino library registry repo. Does that mean all arduino libraries are discoverable by PlatformIO automatically? |
|
No, it is not accessing Arduino registry. But Platformio can use a github repo as lib source. |
d04f041 to
772919b
Compare
|
@Jason2866 I think I will submit the library to the PlatformIO registry - just makes it easier for the board's users. Anyways, I resolved your initial comment and also filled in the PR description. PTAL. Thanks for answering my questions! |
|
Oh, and one more question @Jason2866, is there a way to specify a board support dependence on a library? I know for libraries you can do that through the |
|
@powerfeatherdev Not tried, nor does iknow if something like this exists. If you add an entry after URL / Vendor? I added entrys in local boards.json for my use cases and it does not conflict. |
|
Hi @Jason2866, that's fine if there's not. Just wondering if there was something like that. |
|
@valeros PTAL as well. |
|
@valeros, I assume this is waiting until https://registry.platformio.org/tools/platformio/framework-arduinoespressif32 gets updated to 2.0.15+? |
|
@powerfeatherdev That's right. |
|
Hi @valeros, I see. Is there a timeline for updating it to 2.0.15+? |
This or next week should be available in the dev branch. |
|
I noticed that you enabled the There is also a discrepancy in PSRAM settings, by default it's disabled in the original Arduino config, but in this PR you added the Which settings are correct? |
|
Hi @valeros, I copied the settings from Adafruit ESP32S3 Feather without double checking. Will fix this. Update: Removed, PTAL. |
|
Just my 2 cents. Before it was correct. Board has PSRAM. Arduino setup is wrong. |
|
It seems the definition |
|
Thanks for the PR, merged. |
Adds support for ESP32-S3 PowerFeather (https://powerfeather.dev/). Board uses an 8MB flash, 2MB PSRAM ESP32-S3 module.
Board is supported since Arduino ESP32 2.0.15 release, see merged PRs espressif/arduino-esp32#9325 and espressif/arduino-esp32#9398. Support PR's for the 3.x series has also been merged in espressif/arduino-esp32#8889, espressif/arduino-esp32#9052 and espressif/arduino-esp32#9431 and should be in the next release.
Arduino variant is
esp32s3_powerfeatherwith board nameESP32S3_POWERFEATHER(see https://github.com/espressif/arduino-esp32/blob/master/boards.txt#L35200-L35201)ESP-IDF is also supported, but pin definitions are in the accompaniment library, powerfeather-sdk.