[FIX] Fix metalness and roughness handling in UsdzExporter#8248
Merged
willeastcott merged 1 commit intomainfrom Dec 14, 2025
Merged
[FIX] Fix metalness and roughness handling in UsdzExporter#8248willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect material appearance when exporting PlayCanvas materials to USDZ format. Materials using the specular workflow were incorrectly appearing as shiny metals in USD viewers due to two issues: (1) gloss values were not being inverted to roughness, and (2) specular workflow materials were exporting with their metalness property (which defaults to 1) instead of 0.
Key changes:
- Gloss-to-roughness conversion now matches GltfExporter pattern:
roughness = glossInvert ? gloss : 1 - gloss - Metalness is set to 0 for specular workflow materials (
useMetalness: false) to prevent incorrect metallic appearance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvaligursky
pushed a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect material appearance when exporting to USDZ format. Materials were appearing overly shiny/metallic in USD viewers.
Bug Fixes
Gloss to roughness conversion: USD uses roughness (0=smooth, 1=rough) while PlayCanvas uses gloss (0=rough, 1=smooth). The exporter now correctly inverts the value:
roughness = glossInvert ? gloss : 1 - gloss, matching the behavior in GltfExporter.Metalness for specular workflow: Materials using the specular workflow (
useMetalness: false) were incorrectly exporting theirmetalnessproperty (often defaulting to 1). Now exportsmetallic: 0for specular workflow materials to prevent them appearing as reflective metals.Example
For a material with
shininess: 25(gloss=0.25) anduseMetalness: false:Checklist