Tighten up typing for RigidBodyComponent#type#8292
Merged
willeastcott merged 1 commit intomainfrom Dec 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances type safety for the RigidBodyComponent class by replacing generic type annotations with precise union types for the type property. The changes specify that the property can only accept one of three specific body type constants (BODYTYPE_DYNAMIC, BODYTYPE_KINEMATIC, or BODYTYPE_STATIC), improving code clarity and providing better tooling support for developers.
Key changes:
- Updated the private
_typefield's JSDoc type annotation from implicit to explicit union type - Updated the
typesetter's JSDoc annotation from genericstringto the specific union type - Updated the
typegetter's JSDoc annotation from genericstringto the specific union type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves type safety and documentation for the
typeproperty in theRigidBodyComponentclass by specifying a more precise type annotation. The changes clarify that thetypeproperty can only be one ofBODYTYPE_DYNAMIC,BODYTYPE_KINEMATIC, orBODYTYPE_STATIC, rather than a generic string.Type annotation improvements for
RigidBodyComponent.type:_typeproperty declaration to specify its type asBODYTYPE_DYNAMIC|BODYTYPE_KINEMATIC|BODYTYPE_STATICinstead of a generic type.typeto use the more precise type annotation, improving code clarity and tooling support. [1] [2]Checklist