[FIX] Fix screen space particles when CPU simulation is used#8301
Merged
willeastcott merged 1 commit intomainfrom Dec 21, 2025
Merged
[FIX] Fix screen space particles when CPU simulation is used#8301willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where screen space particles were not rendering correctly when CPU simulation was used (either forced or when sorting is enabled). The fix adds the missing SCREEN_SPACE conditional handling to the CPU particle shaders, making them consistent with the GPU particle shaders.
Key Changes:
- Added
SCREEN_SPACEhandling to the CPU particle billboard function in both GLSL and WGSL - Added
SCREEN_SPACEhandling to the CPU particle position output in both GLSL and WGSL
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scene/shader-lib/wgsl/chunks/particle/vert/particle_cpu_end.js | Added conditional logic to output position directly to NDC for screen space particles instead of transforming through view-projection matrix |
| src/scene/shader-lib/wgsl/chunks/particle/vert/particle_cpu.js | Added conditional logic to use axis-aligned billboarding for screen space particles instead of view-inverse matrix billboarding |
| src/scene/shader-lib/glsl/chunks/particle/vert/particle_cpu_end.js | Added conditional logic to output position directly to NDC for screen space particles instead of transforming through view-projection matrix |
| src/scene/shader-lib/glsl/chunks/particle/vert/particle_cpu.js | Added conditional logic to use axis-aligned billboarding for screen space particles instead of view-inverse matrix billboarding |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7534
When
screenSpace: trueis set on a particle system and CPU particles are used (either forced viadevice.supportsGpuParticles = falseor when sorting is enabled), screen space particles were not rendering correctly.Changes
SCREEN_SPACEhandling to the CPU particlebillboardfunction in both GLSL and WGSL shadersSCREEN_SPACEhandling to the CPU particle position output in both GLSL and WGSL shadersRoot Cause
The GPU particle shaders had proper
SCREEN_SPACEconditional handling, but the CPU particle shaders were missing this logic entirely. This caused CPU particles to:Testing
Tested with the
user-interface/particle-systemexample with CPU particles forced via:Checklist