Allow changing unified property without disabling component#8334
Merged
mvaligursky merged 1 commit intomainfrom Jan 5, 2026
Merged
Allow changing unified property without disabling component#8334mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
willeastcott
reviewed
Jan 5, 2026
| * | ||
| * Note: Material handling differs between modes. When unified is false, use | ||
| * {@link GSplatComponent#material}. When unified is true, materials are shared per | ||
| * camera/layer - use {@link GSplatComponentSystem#getGSplatMaterial} instead. |
Contributor
There was a problem hiding this comment.
I'm not a fan of this naming. I prefer something like GSplatComponentSystem#getMaterial.
Contributor
Author
There was a problem hiding this comment.
yep good point, will address separately.
willeastcott
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
GSplatComponent.unifiedproperty to be changed at runtime without requiring manual disable/enable of the component.Changes
unifiedsetter to automatically destroy and recreate internal data (instance/placement) when the value changesBefore
After