[FIX] Fix controller models in XR movement example#8390
Merged
willeastcott merged 1 commit intomainfrom Jan 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical bugs and deprecation issues in the XR VR movement example that prevented controllers from displaying and updating correctly.
Changes:
- Fixed missing parentheses on
getLocalPosition()andgetLocalRotation()method calls that were causing function references to be passed instead of actual position/rotation values - Replaced deprecated
modelcomponent withrendercomponent for controller visualization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
added a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLocalPosition()andgetLocalRotation()method calls that were passing function references instead of calling the methodsmodelcomponent withrendercomponent for controller visualizationDetails
The example had two issues:
Bug fix:
inputSource.getLocalPositionandinputSource.getLocalRotationwere missing parentheses, causing the controller entities to receive function references instead of Vec3/Quat values. This prevented controller positions from updating correctly.Deprecation cleanup: Replaced the deprecated
modelcomponent with therendercomponent for the controller box entities.Checklist