Skip to content

[FIX] Fix controller models in XR movement example#8390

Merged
willeastcott merged 1 commit intomainfrom
fix-movement
Jan 20, 2026
Merged

[FIX] Fix controller models in XR movement example#8390
willeastcott merged 1 commit intomainfrom
fix-movement

Conversation

@willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 20, 2026

Summary

image
  • Fix missing parentheses on getLocalPosition() and getLocalRotation() method calls that were passing function references instead of calling the methods
  • Replace deprecated model component with render component for controller visualization

Details

The example had two issues:

  1. Bug fix: inputSource.getLocalPosition and inputSource.getLocalRotation were missing parentheses, causing the controller entities to receive function references instead of Vec3/Quat values. This prevented controller positions from updating correctly.

  2. Deprecation cleanup: Replaced the deprecated model component with the render component for the controller box entities.

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@willeastcott willeastcott requested a review from Copilot January 20, 2026 19:04
@willeastcott willeastcott self-assigned this Jan 20, 2026
@willeastcott willeastcott changed the title [FIX] Fix controller models in XR movement examle [FIX] Fix controller models in XR movement example Jan 20, 2026
@willeastcott willeastcott merged commit 1925caf into main Jan 20, 2026
7 checks passed
@willeastcott willeastcott deleted the fix-movement branch January 20, 2026 19:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes critical bugs and deprecation issues in the XR VR movement example that prevented controllers from displaying and updating correctly.

Changes:

  • Fixed missing parentheses on getLocalPosition() and getLocalRotation() method calls that were causing function references to be passed instead of actual position/rotation values
  • Replaced deprecated model component with render component for controller visualization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants