[FIX] Fix XrInputSource JSDoc errors and redundant code#8391
Merged
willeastcott merged 1 commit intomainfrom Jan 20, 2026
Merged
[FIX] Fix XrInputSource JSDoc errors and redundant code#8391willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes multiple JSDoc documentation errors and removes redundant code in the XrInputSource class. The changes improve documentation accuracy and code clarity without affecting functionality.
Changes:
- Fixed JSDoc grammar and typo in event documentation
- Corrected event name in code example to match actual event constant
- Fixed incorrect JSDoc return descriptions for local space methods
- Eliminated redundant property access by reusing existing variable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
added a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'remove'→'hittest:remove'@returnsdescriptions forgetLocalPosition()andgetLocalRotation()to correctly say "local space" instead of "world space"parentvariable instead of redundantthis._manager.camera.parentaccessChecklist