Skip to content

[FIX] Fix XrInputSource JSDoc errors and redundant code#8391

Merged
willeastcott merged 1 commit intomainfrom
xrinput-fixes
Jan 20, 2026
Merged

[FIX] Fix XrInputSource JSDoc errors and redundant code#8391
willeastcott merged 1 commit intomainfrom
xrinput-fixes

Conversation

@willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 20, 2026

Summary

  • Fix JSDoc typo: "removed to the the" → "removed from the"
  • Fix incorrect event name in example: 'remove''hittest:remove'
  • Fix @returns descriptions for getLocalPosition() and getLocalRotation() to correctly say "local space" instead of "world space"
  • Use existing parent variable instead of redundant this._manager.camera.parent access

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

@willeastcott willeastcott requested a review from Copilot January 20, 2026 19:45
@willeastcott willeastcott self-assigned this Jan 20, 2026
@willeastcott willeastcott added the area: xr XR related issue label Jan 20, 2026
@willeastcott willeastcott merged commit 97d5a59 into main Jan 20, 2026
7 checks passed
@willeastcott willeastcott deleted the xrinput-fixes branch January 20, 2026 19:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes multiple JSDoc documentation errors and removes redundant code in the XrInputSource class. The changes improve documentation accuracy and code clarity without affecting functionality.

Changes:

  • Fixed JSDoc grammar and typo in event documentation
  • Corrected event name in code example to match actual event constant
  • Fixed incorrect JSDoc return descriptions for local space methods
  • Eliminated redundant property access by reusing existing variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: xr XR related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants