Modernize legacy posteffect scripts to ES6 classes and fix FXAA offset bug#8397
Merged
mvaligursky merged 2 commits intomainfrom Jan 22, 2026
Merged
Modernize legacy posteffect scripts to ES6 classes and fix FXAA offset bug#8397mvaligursky merged 2 commits intomainfrom
mvaligursky merged 2 commits intomainfrom
Conversation
willeastcott
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize legacy posteffect scripts to ES6 classes and fix FXAA offset bug
Fixes #5218
Updates all legacy posteffect scripts in
scripts/posteffects/from ES5 prototype-based inheritance to modern ES6 class syntax, and fixes a long-standing FXAA texture offset bug.Changes
ES6 Class Modernization (all 14 posteffect files)
class extends pc.PostEffectpc.PostEffect.call(this, graphicsDevice)withsuper(graphicsDevice)Object.create,Object.assign, etc.)vardeclarations toconst/let[...].join('\n')to template literals with/* glsl */tag for editor syntax highlightingFXAA Fix
textureOffset()for proper 1-texel sampling and better GPU performanceUpdated Files
posteffect-blend.jsposteffect-bloom.jsposteffect-bokeh.jsposteffect-brightnesscontrast.jsposteffect-edgedetect.jsposteffect-fxaa.jsposteffect-horizontaltiltshift.jsposteffect-huesaturation.jsposteffect-luminosity.jsposteffect-outline.jsposteffect-sepia.jsposteffect-ssao.jsposteffect-verticaltiltshift.jsposteffect-vignette.js