Fix unified gsplat work buffer extra streams for octrees and color-only updates#8405
Merged
mvaligursky merged 1 commit intomainfrom Jan 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues with unified gsplat work buffer extra streams:
Changes:
- Added parent placement delegation for octree file placements to inherit shader configuration (
workBufferModifierand instancestreams) - Implemented no-op stub generation for extra stream write functions in color-only mode to prevent shader compilation errors
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/scene/shader-lib/wgsl/chunks/gsplat/vert/gsplatStreamOutput.js | Added {defineGuard} placeholder to enable conditional compilation of stream output |
| src/scene/shader-lib/glsl/chunks/gsplat/vert/gsplatStreamOutput.js | Added {defineGuard} placeholder to enable conditional compilation of stream output |
| src/scene/gsplat/gsplat-format.js | Added getOutputStubs method to generate no-op stub functions for streams |
| src/scene/gsplat/gsplat-resource-base.js | Modified to generate stub functions for extra streams in color-only mode |
| src/scene/gsplat-unified/gsplat-placement.js | Added parent placement support with delegation for workBufferModifier and streams getters |
| src/scene/gsplat-unified/gsplat-octree-instance.js | Updated file placement creation to pass parent placement reference |
| src/scene/gsplat-unified/gsplat-info.js | Changed instanceStreams from property to getInstanceStreams getter function for live retrieval |
| src/scene/gsplat-unified/gsplat-work-buffer-render-pass.js | Updated to use getInstanceStreams function for live stream access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two related issues with unified gsplat work buffer extra streams:
1. Octree parent placement delegation
Octree file placements now properly inherit shader configuration from the component's placement, enabling them to write to work buffer extra streams:
workBufferModifier- delegated via getter (allows writing to extra streams)parameters- inherited in constructor (e.g., component ID uniforms)streams(instance textures) - delegated via getterThis allows octree splats to use per-component parameters and modifiers when writing to work buffer extra streams
2. Color-only shader compilation fix
When camera movement triggers a color-only update (spherical harmonics recalculation), the work buffer shader now generates no-op stub functions for extra stream writes. This prevents shader compilation errors when the user's
workBufferModifiercalls functions likewriteSplatComponentId()that don't have render targets in color-only mode.