Add pattern fill for scatter filled area#6101
Merged
archmoj merged 5 commits intoplotly:masterfrom Feb 18, 2022
Merged
Conversation
archmoj
added
status: reviewable
community
archmoj
reviewed
Feb 1, 2022
archmoj
reviewed
Feb 1, 2022
Contributor
|
Looking good now. |
alexcjohnson
approved these changes
Feb 18, 2022
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Thanks @s417-lama - the one thing I was a little concerned about is removing fullLayout._*UrlQueryParts, just because I'm not really sure why that solution was added in the first place. But I think your class-based solution is better anyway, it's certainly simpler and clearer!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern fill for bar (and related trace types) has been added in #5520, but no pattern fill was available for scatter's filled area plots.
This PR adds pattern fill for scatter filled area.
I would like to add pattern fill for other trace types (box, violin, etc.) as well in the future, but this PR only includes scatter.
Sample file:
(By the way, how can I run
test-imagelocally? The workflow has been changed since I created my last PR, and how to runtest-imageseems not described inCONTRIBUTING.md.)