Minor change so links to actual/expected xml files are relative links, so they can be served through jenkins#1
Open
trammel wants to merge 1 commit intopmoran:masterfrom
Open
Minor change so links to actual/expected xml files are relative links, so they can be served through jenkins#1trammel wants to merge 1 commit intopmoran:masterfrom
trammel wants to merge 1 commit intopmoran:masterfrom
Conversation
…re web-server friendly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altered links to actual/expected files to be relative links, to be more web-server friendly.
It's a very cool matcher, still very useful. The code I added doesn't feel 100% right, but without pulling apart @report_dir and @generated_xml_dir further, I don't see how else to achieve this.
-JP