Repository navigation
Write PR review guides and read thread PRs from t3_thread_list - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts two opportunities that earlier contract PRs listed but nobody adopted: review guides from #7 and
pullRequestsint3_thread_listfrom #32. All edits are inskills/poteto-mode/references/t3-adapter.md.Changes
write_pull_request_guides,read_pull_request_guide). A new "Review guides" bullet under "Pull requests, watching, and loops": when the root hands PRs to the user for review or merge, it reads each guide. Then it callswrite_pull_request_guidesonce for every PR whose guide is missing orstale. It does not wait for the runs. A PR whose outcome isfailedgets no guide, and the reply gives thedetail. The bullet passes PRs asrepositoryandnumber. On the installed T3,read_pull_request_guidewith the PRurlfailed with "No project in this environment is a checkout of pmwoz/t3-pstack". The same PR asrepositoryandnumberreturned its guide state.pullRequestsint3_thread_list. "Listing worktrees" and "A Cursor restart" now say thatt3_thread_listreturns each thread's linked PRs and their state. The worktree audit needs nolist_thread_pull_requestscall per thread.Scope
The opportunities
runtimeModes(#5) andt3_workflow_stop(#5) stay out. Every provider that can run a child task allows every runtime mode, and no skill starts a Claude workflow. The Shipping playbook is unchanged because the agent merges there itself and no person reads a guide.Version
0.9.2 to 0.9.3 (patch, because the adapter changed).
Checks
bun run check: 234 plugin files, 13 drift entries, upstream 0.15.29 @ 88d4751, T3 @ b232fa9bun test tools: 37 passbun run typecheck: passwrite_pull_request_guidesfor this PR returnedoutcome: "failed"with "Review guides are off. Turn them on in Settings → Source Control." The call itself succeeds, so the bullet handles the per-PR outcome, not a tool error. A written guide was not observed.