Skip to content

Conversation

@greenberga
Copy link
Contributor

@greenberga greenberga commented Aug 22, 2018

Closes #1396

@greenberga greenberga force-pushed the instructions-bar-edit-button branch 2 times, most recently from d48cdd8 to 3393bfe Compare August 22, 2018 00:43
Copy link
Contributor

@outoftime outoftime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greenberga nice! a few thoughts………

  1. Maybe less than 100% opacity?
  2. Maybe only do the hover thing if the bar is open?
  3. Maybe move the edit button to the bottom of the bar?
  4. The bar width changes slightly between edit and normal mode (i think the edit icon is pushing it out a bit) which will surely drive me mad
  5. A linter error : )

@greenberga
Copy link
Contributor Author

greenberga commented Aug 28, 2018

I had actually meant to bring up the changing bar width! Seems like I didn't have to though 🙂 Any idea what might be causing that? It's weird because the characters seem to have the same width...

All good ideas! Will get to implementing them.

@outoftime
Copy link
Contributor

@greenberga soooo weirdly now I can’t repro the width changing!? even though i still have the same commit checked out…

anywho, also occurred to me that a quick transition on the opacity (fade in/out) would be nice ; )

@greenberga greenberga force-pushed the instructions-bar-edit-button branch from 3393bfe to 7c6b559 Compare September 9, 2018 03:33
@greenberga
Copy link
Contributor Author

I can still reproduce the changing width in Firefox...I wonder if it's just because the icon is a different size? Let me try switching icons and see if that fixes it.

This keeps the width of the instructions bar from changing.
@greenberga
Copy link
Contributor Author

@outoftime okay, I think I did all the things! Would you mind taking another look when you have the time?

Copy link
Contributor

@outoftime outoftime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@outoftime outoftime merged commit 38fb534 into popcodeorg:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants