-
Notifications
You must be signed in to change notification settings - Fork 141
Add subtle edit button to instructions bar #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtle edit button to instructions bar #1551
Conversation
d48cdd8 to
3393bfe
Compare
outoftime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greenberga nice! a few thoughts………
- Maybe less than 100% opacity?
- Maybe only do the hover thing if the bar is open?
- Maybe move the edit button to the bottom of the bar?
- The bar width changes slightly between edit and normal mode (i think the edit icon is pushing it out a bit) which will surely drive me mad
- A linter error : )
|
I had actually meant to bring up the changing bar width! Seems like I didn't have to though 🙂 Any idea what might be causing that? It's weird because the characters seem to have the same width... All good ideas! Will get to implementing them. |
|
@greenberga soooo weirdly now I can’t repro the width changing!? even though i still have the same commit checked out… anywho, also occurred to me that a quick transition on the opacity (fade in/out) would be nice ; ) |
3393bfe to
7c6b559
Compare
|
I can still reproduce the changing width in Firefox...I wonder if it's just because the icon is a different size? Let me try switching icons and see if that fixes it. |
This keeps the width of the instructions bar from changing.
|
@outoftime okay, I think I did all the things! Would you mind taking another look when you have the time? |
outoftime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
Closes #1396