Add a space in complex anonymous functions#236
Merged
DavisVaughan merged 5 commits intomainfrom Feb 20, 2025
Merged
Conversation
lionel-
approved these changes
Feb 20, 2025
Collaborator
lionel-
left a comment
lionel-
left a comment
There was a problem hiding this comment.
Do we have tests for chained unary formulas?
It should look like:
~~foo
~~ 1 + 2
Comment on lines
48
to
50
| // "Complex" is anything except identifiers | ||
| !matches!(argument, AnyRExpression::RIdentifier(_)) |
Collaborator
There was a problem hiding this comment.
I would expect ~NA and ~NULL to be treated like ~foo?
And probably other literals like ~10 too?
Collaborator
Author
There was a problem hiding this comment.
I don't think so, I believe that this behavior is only for identifiers. And is somewhat special to supporting tribble calls
tribble(
~x, ~y,
...
)If not for tribble I would have been happy with unconditionally using a space between the ~ and the rhs, so to me the ~foo behavior is just a surgical patch to help that, and everything else gets a space
DavisVaughan
force-pushed
the
feature/unary-formula
branch
from
a789fa6 to
937b814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235