Skip to content

locals at each node overwrite locals difined globally #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scrum merged 2 commits into from
May 13, 2022
Merged

locals at each node overwrite locals difined globally #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06a8653
feat: take priority locals at each node over locals at global options
nokazn Apr 9, 2022
602599d
test: add test for override locals defined globally
nokazn Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module.exports = (options = {}) => {
const localsJson = JSON.parse(localsRaw);
posthtmlExpressionsOptions = {
...posthtmlExpressionsOptions,
locals: posthtmlExpressionsOptions.locals ? Object.assign(localsJson, posthtmlExpressionsOptions.locals) : localsJson
locals: posthtmlExpressionsOptions.locals ? Object.assign(posthtmlExpressionsOptions.locals, localsJson) : localsJson
};
} catch {}

Expand Down
3 changes: 3 additions & 0 deletions test/expected/override-global-variables.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div>Should override global locals</div>
<div>local</div>
<div>local</div>
3 changes: 3 additions & 0 deletions test/fixtures/override-global-variables.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div>Should override global locals</div>
<div>local</div>
<div>local</div>
7 changes: 7 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ test('Should merge global locals', t => {
}})
})

test('Should override global locals', t => {
return process(t, 'override-global-variables', {
posthtmlExpressionsOptions: {
locals: {globalVariable: 'global'}
}})
})

test('Should merge global variables and evaluate each local variable', t => {
return process(t, 'multiple-include', {
posthtmlExpressionsOptions: {
Expand Down