adds active directory credential type

[praetorian-matt-schneider]

No description provided.

[github-actions]

Claude finished @praetorian-matt-schneider's task —— View job

---

Code Review: adds active directory credential type

Has Go, TypeScript, or Python Changes: Yes
Has Significant Changes: No
Has Automated Tests: No

Findings

• Single line addition of ActiveDirectoryCredential constant in pkg/model/model/credential.go:34
• Change adds new credential type "active-directory" with descriptive comment for Aegis capabilities
• Minimal whitespace formatting adjustments to align comments consistently
• No test coverage exists for the Credential model in the test suite
• Change follows existing code patterns and naming conventions

Recommendations

• Add unit tests for the Credential model, including the new ActiveDirectoryCredential type
• Consider adding validation tests for the new credential type in the Valid() method
• Verify integration with the broader Aegis system that will consume this credential type
• Document expected credential format/structure for Active Directory credentials if not already defined

---

[coderabbitai]

Walkthrough

Adds a new credential type constant ActiveDirectoryCredential with value active-directory to the CredentialType enum. Also adds a new public field CredentialIDs []string to the Job struct with tags dynamodbav:"credentialIDs,omitempty" and json:"credentialIDs,omitempty". Minor formatting changes were made in the credential const block.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch aegiscreds

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e5ebdf0 and b970be4.

📒 Files selected for processing (1)

• pkg/model/model/job.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

pkg/model/{model,attacksurface,beta}/**/*.go

📄 CodeRabbit inference engine (CLAUDE.md)

pkg/model/{model,attacksurface,beta}/**/*.go: Register every new model in its init() using registry.Registry.MustRegisterModel(&ModelName{})
Model structs must embed BaseAsset
All model fields must include json and desc struct tags for proper schema generation
Where applicable, include neo4j and example struct tags on model fields

Files:

• pkg/model/model/job.go

🔇 Additional comments (1)

pkg/model/model/job.go (1)

30-30: LGTM! Field properly defined with all required tags.

The CredentialIDs field follows the struct's conventions and includes all necessary tags (json, desc, example). The omitempty flags are appropriate since not all jobs require credentials.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Claude finished @praetorian-matt-schneider's task —— View job

---

Code Review: adds active directory credential type

Has Go, TypeScript, or Python Changes: Yes
Has Significant Changes: No
Has Automated Tests: No

Todo List

• Read changed files to understand modifications
• Check for corresponding test files
• Analyze change significance
• Provide structured review feedback

Findings

• Adds ActiveDirectoryCredential constant with value "active-directory" to credential types in pkg/model/model/credential.go:34
• Includes descriptive comment explaining purpose for Aegis capabilities with username, password, and domain
• Adds CredentialIDs field to Job struct in pkg/model/model/job.go:30 for credential injection into job execution
• Both changes follow existing code patterns with proper struct tags and formatting
• No test coverage exists for either the Credential or Job model additions
• BurpSuiteInternalCredential (line 54) remains present despite CodeRabbit comment suggesting removal
• Changes are minimal and follow established conventions in the codebase

Recommendations

• Add unit tests for the new ActiveDirectoryCredential type validation in Credential.Valid() method
• Create missing credential_test.go file to test credential model functionality
• Add tests for the new CredentialIDs field in existing job_test.go
• Verify the new credential type integrates correctly with the Aegis system
• Document expected structure/format for Active Directory credentials if not already defined elsewhere

[github-actions]

Claude finished @praetorian-matt-schneider's task —— View job

---

Code Review: adds active directory credential type

Has Go, TypeScript, or Python Changes: Yes
Has Significant Changes: No
Has Automated Tests: No

Todo List

• Read changed files to understand modifications
• Check for corresponding test files
• Analyze change significance
• Provide structured review feedback

Findings

• Adds ActiveDirectoryCredential constant with value "active-directory" to credential types in pkg/model/model/credential.go:34
• Includes descriptive comment explaining purpose for Aegis capabilities with username, password, and domain
• Adds CredentialIDs field to Job struct in pkg/model/model/job.go:30 for credential injection into job execution
• Both changes follow existing code patterns with proper struct tags and formatting
• No test coverage exists for either the Credential or Job model additions
• BurpSuiteInternalCredential (line 54) remains present despite CodeRabbit comment suggesting removal
• Changes are minimal and follow established conventions in the codebase

Recommendations

• Add unit tests for the new ActiveDirectoryCredential type validation in Credential.Valid() method
• Create missing credential_test.go file to test credential model functionality
• Add tests for the new CredentialIDs field in existing job_test.go
• Verify the new credential type integrates correctly with the Aegis system
• Document expected structure/format for Active Directory credentials if not already defined elsewhere