Add in a used_width method to the Formatted::Box class#1259
Open
urkle wants to merge 1 commit intoprawnpdf:masterfrom
Open
Add in a used_width method to the Formatted::Box class#1259urkle wants to merge 1 commit intoprawnpdf:masterfrom
urkle wants to merge 1 commit intoprawnpdf:masterfrom
Conversation
- this method returns the used width of the text printed within (account for line wrapping) - this will be used by the prawn-table gem to support fallback fonts properly
This was referenced Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR needed to solve prawnpdf/prawn-table#80
This is designed to be minimally invasive to get the base functionality needed.
A better, more efficient approach would require more significant refactoring of the fallback font code such that we could have a width_of style method on the PDF document that would utilize fallback fonts in its calculation.