Conversation
mrbelowski
reviewed
Jun 17, 2024
lua-api/lib/src/ScriptContext.cpp
Outdated
| const auto desc = c->find_property(name.c_str()); | ||
|
|
||
| if (desc == nullptr) { | ||
| return; |
Contributor
There was a problem hiding this comment.
should these early returns log something to help the script developer? If the property / class isn't found (typo, wrong path, whatever) then the failing set_property call might go unnoticed
mrbelowski
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important additions
<config folder>/scripts/*.luaLua API improvements
Properties can now be accessed and set
UObject*elements)TODO:
StructProperty (vectors etc),ClassProperty,ByteProperty,EnumPropertyFunctions can now be called on objects
ex:
TODO:
StructProperty (vectors etc), Array parameters, out parameters,ByteProperty,EnumProperty