Preserve whitespace for pre/textarea when pretty-printing#432
Merged
rschristian merged 2 commits intoSep 30, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 96dfd13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
approved these changes
Sep 30, 2025
Member
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
Seems reasonable but I'm a bit worried this might break folks using pretty printing in their test suites and the like. Pretty specific tags & change scenarios though, so perhaps the risk is low
rschristian
reviewed
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<pre>and<textarea>are whitespace-sensitive. When pretty-printing, it's important to not inject extra whitespace when rendering them.There may be more tags for which whitespace should be preserved; these are the two that I specifically know about.
Disclosure: I wrote the tests by hand and used GPT-5-Codex to help with the implementation.