Skip to content

Tests: Improve console.logs #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 4 commits into from
Jan 26, 2021
Merged

Tests: Improve console.logs #2959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e649dc
Test: Fix duplicate console logs
marvinhagemeister Jan 22, 2021
faf6f9a
Test: Fix HTML elements logged as objects
marvinhagemeister Jan 24, 2021
207e427
Merge branch 'master' into duplicate-console
marvinhagemeister Jan 24, 2021
e0b0b72
Merge branch 'master' into duplicate-console
marvinhagemeister Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ const fs = require('fs').promises;
const orgStdoutWrite = process.stdout.write;
process.stdout.write = msg => {
let out = '';
const match = msg.match(/(^|.*\s)(LOG|WARN|ERROR):\s'([\s\S]*)'/);
const match = msg.match(
/(^|.*\s)(LOG|WARN|ERROR):\s'__LOG_CUSTOM:([\S\s]*)'/
);
if (match && match.length >= 4) {
// Sometimes the UA of the browser will be included in the message
if (match[1].length) {
Expand All @@ -29,6 +31,8 @@ process.stdout.write = msg => {
out += match[3];
}
out += '\n';
} else if (/(^|.*\s)(LOG|WARN|ERROR):\s([\S\s]*)/.test(msg)) {
// Nothing
} else {
out = msg;
}
Expand Down
7 changes: 6 additions & 1 deletion test/polyfills.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function patchConsole(method) {
window.console[method] = (...args) => {
// @ts-ignore
// eslint-disable-next-line no-undef
__karma__.log(method, serializeConsoleArgs(args));
__karma__.log(method, ['__LOG_CUSTOM:' + serializeConsoleArgs(args)]);
original.apply(window.console, args);
};
}
Expand Down Expand Up @@ -197,6 +197,10 @@ function serialize(value, mode, indent, seen) {
return kl.cyan(`[Function: ${value.name || 'anonymous'}]`);
}

if (value instanceof Element) {
return value.outerHTML;
}

seen.add(value);

const props = Object.keys(value).map(key => {
Expand Down Expand Up @@ -253,3 +257,4 @@ function serialize(value, mode, indent, seen) {
// new Set([1, 2]),
// new Map([[1, 2]])
// );
// console.log(document.createElement('div'));