Add decoding TypeScript attribute

[sumanthratna]

currently, when I try using:

<img src="..." decoding="async" />

I get this error:

TS2322: Type '{ alt: string; src: string; style: { width: string; height: string; }; className: string; decoding: string; }' is not assignable to type 'HTMLAttributes<HTMLImageElement>'.
  Property 'decoding' does not exist on type 'HTMLAttributes<HTMLImageElement>'.

this patch fixes this issue

[coveralls]

Coverage remained the same at 99.445% when pulling 82c827e on sumanthratna:patch-1 into 605bc5e on preactjs:master.

[rschristian]

If you look at where you added that type, those are all HTML elements. What you did was make <decoding /> a valid HTML element, and it's the type of a HTMLImageElement.

What you'll actually want to do is create a decoding entry under the HTMLAttributes and set it so it matches the attribute's options.

Like this:

decoding?: 'sync' | 'async' | 'auto';

[sumanthratna]

If you look at where you added that type, those are all HTML elements. What you did was make <decoding /> a valid HTML element, and it's the type of a HTMLImageElement.

What you'll actually want to do is create a decoding entry under the HTMLAttributes and set it so it matches the attribute's options.

Like this:

decoding?: 'sync' | 'async' | 'auto';

whoops, too many types to keep track of :) should be fixed now @rschristian. thanks for taking a look at this PR!

[rschristian]

Thanks!

[sumanthratna]

@rschristian I know this just got merged but do you have an ETA on the next release?

[rschristian]

I do not, but what you can do is manually add the types until then:

declaration.d.ts

interface HotPatch {
	decoding?: 'sync' | 'async' | 'auto';
}

declare module 'preact' {
	namespace JSX {
		interface IntrinsicAttributes extends HotPatch {}
	}
	interface Attributes extends HotPatch {}
}

Should silence any errors you'd get