Remove contains with a simple parentNode check

[JoviDeCroock]

We basically want to check whether the following node is unmounted, which can also be done by checking for the presence of parentNode

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -0% - +0% (-3.64ms - +3.85ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +1% (-0.03ms - +0.09ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +3% (-0.49ms - +2.37ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -1% - +0% (-0.21ms - +0.06ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +1% (-0.66ms - +0.38ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +2% (-0.10ms - +0.05ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -2% - +4% (-0.69ms - +1.54ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -5% - +1% (-1.64ms - +0.46ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -1% - +2% (-0.02ms - +0.03ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -4% - +3% (-0.41ms - +0.34ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -1% - +1% (-0.03ms - +0.02ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -1% - +3% (-0.01ms - +0.03ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -1% - +0% (-0.04ms - +0.01ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	927.28ms - 931.42ms	-	unsure 🔍 -0% - +0% -3.64ms - +3.85ms
preact-main	926.13ms - 932.36ms	unsure 🔍 -0% - +0% -3.85ms - +3.64ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.20ms - 19.22ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.01ms
preact-main	19.20ms - 19.22ms	unsure 🔍 -0% - +0% -0.01ms - +0.02ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.56ms - 16.67ms	-	unsure 🔍 -0% - +1% -0.03ms - +0.09ms
preact-main	16.57ms - 16.61ms	unsure 🔍 -1% - +0% -0.09ms - +0.03ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.53ms - 1.57ms	-	unsure 🔍 -1% - +2% -0.02ms - +0.03ms
preact-main	1.52ms - 1.56ms	unsure 🔍 -2% - +1% -0.03ms - +0.02ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	77.24ms - 79.24ms	-	unsure 🔍 -1% - +3% -0.49ms - +2.37ms
preact-main	76.28ms - 78.32ms	unsure 🔍 -3% - +1% -2.37ms - +0.49ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	10.60ms - 11.04ms	-	unsure 🔍 -4% - +3% -0.41ms - +0.34ms
preact-main	10.55ms - 11.16ms	unsure 🔍 -3% - +4% -0.34ms - +0.41ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.38ms - 16.64ms	-	unsure 🔍 -1% - +0% -0.21ms - +0.06ms
preact-main	16.55ms - 16.61ms	unsure 🔍 -0% - +1% -0.06ms - +0.21ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.76ms - 3.80ms	-	unsure 🔍 -1% - +1% -0.03ms - +0.02ms
preact-main	3.77ms - 3.81ms	unsure 🔍 -1% - +1% -0.02ms - +0.03ms	-

replace1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	66.02ms - 66.71ms	-	unsure 🔍 -1% - +1% -0.66ms - +0.38ms
preact-main	66.11ms - 66.90ms	unsure 🔍 -1% - +1% -0.38ms - +0.66ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.97ms - 3.00ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	2.97ms - 2.99ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.67ms - 30.31ms	-	unsure 🔍 -2% - +2% -0.50ms - +0.49ms
preact-main	29.61ms - 30.37ms	unsure 🔍 -2% - +2% -0.49ms - +0.50ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.37ms - 34.39ms	-	unsure 🔍 -2% - +2% -0.73ms - +0.62ms
preact-main	33.49ms - 34.38ms	unsure 🔍 -2% - +2% -0.62ms - +0.73ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.45ms - 25.79ms	-	unsure 🔍 -2% - +1% -0.48ms - +0.22ms
preact-main	25.45ms - 26.06ms	unsure 🔍 -1% - +2% -0.22ms - +0.48ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.66ms - 25.81ms	-	unsure 🔍 -4% - +2% -1.03ms - +0.59ms
preact-main	24.88ms - 26.02ms	unsure 🔍 -2% - +4% -0.59ms - +1.03ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.03ms - 26.23ms	-	unsure 🔍 -2% - +5% -0.43ms - +1.22ms
preact-main	24.67ms - 25.80ms	unsure 🔍 -5% - +2% -1.22ms - +0.43ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.13ms - 20.53ms	-	unsure 🔍 -1% - +2% -0.27ms - +0.32ms
preact-main	20.09ms - 20.52ms	unsure 🔍 -2% - +1% -0.32ms - +0.27ms	-

text-update

• Browser: chrome-headless
• Sample size: 140
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.07ms - 2.18ms	-	unsure 🔍 -5% - +2% -0.10ms - +0.05ms
preact-main	2.10ms - 2.20ms	unsure 🔍 -2% - +5% -0.05ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.12ms - 1.12ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.12ms - 1.12ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.66ms - 35.87ms	-	unsure 🔍 -2% - +4% -0.69ms - +1.54ms
preact-main	34.18ms - 34.50ms	unsure 🔍 -4% - +2% -1.54ms - +0.69ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.23ms - 1.26ms	-	unsure 🔍 -1% - +3% -0.01ms - +0.03ms
preact-main	1.22ms - 1.25ms	unsure 🔍 -3% - +1% -0.03ms - +0.01ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 60
• Built by: CI #4395

• Commit: 5f79e91

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.38ms - 34.65ms	-	unsure 🔍 -5% - +1% -1.64ms - +0.46ms
preact-main	33.77ms - 35.44ms	unsure 🔍 -1% - +5% -0.46ms - +1.64ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.93ms - 2.96ms	-	unsure 🔍 -1% - +0% -0.04ms - +0.01ms
preact-main	2.94ms - 2.98ms	unsure 🔍 -0% - +1% -0.01ms - +0.04ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: -50 B (-0.11%)

Total Size: 46.6 kB

Filename	Size	Change
compat/dist/compat.js	3.77 kB	-12 B (-0.32%)
compat/dist/compat.mjs	3.68 kB	-11 B (-0.3%)
compat/dist/compat.umd.js	3.82 kB	-11 B (-0.29%)
dist/preact.js	4.58 kB	-6 B (-0.13%)
dist/preact.mjs	4.6 kB	-5 B (-0.11%)
dist/preact.umd.js	4.68 kB	-5 B (-0.11%)

ℹ️ View Unchanged

Filename	Size
debug/dist/debug.js	3.87 kB
debug/dist/debug.mjs	3.87 kB
debug/dist/debug.umd.js	3.95 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.mjs	270 B
devtools/dist/devtools.umd.js	346 B
hooks/dist/hooks.js	1.55 kB
hooks/dist/hooks.mjs	1.58 kB
hooks/dist/hooks.umd.js	1.62 kB
jsx-runtime/dist/jsxRuntime.js	861 B
jsx-runtime/dist/jsxRuntime.mjs	830 B
jsx-runtime/dist/jsxRuntime.umd.js	934 B
test-utils/dist/testUtils.js	473 B
test-utils/dist/testUtils.mjs	473 B
test-utils/dist/testUtils.umd.js	555 B

_{compressed-size-action}