Showheroes Bid Adapter: rename showheroes bid adapter#14644
Showheroes Bid Adapter: rename showheroes bid adapter#14644FilipStamenkovic wants to merge 1 commit intoprebid:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5003925aef
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| const ENDPOINT = 'https://ads.viralize.tv/openrtb2/auction/'; | ||
| const BIDDER_CODE = 'showheroes-bs'; | ||
| const BIDDER_CODE = 'showheroes'; |
There was a problem hiding this comment.
Changing BIDDER_CODE to showheroes and relying on aliases keeps runtime bidder aliases working, but it does not preserve the old module include name (showheroes-bsBidAdapter) that publishers pass to the build CLI. Because the file was renamed, custom builds that still request the legacy module name now hit the invalid modules path in bundle() (gulpfile.js validates requested module names before bundling), so the intended backward compatibility is incomplete unless you keep a legacy module entry point (e.g., a shim file that re-exports this adapter).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR renames the ShowHeroes bidder code from showheroes-bs to showheroes, while keeping showheroes-bs as an alias for backward compatibility within the Prebid.js bidder adapter ecosystem.
Changes:
- Update the adapter’s primary
BIDDER_CODEtoshowheroesand addshowheroes-bsas an alias. - Update the adapter unit tests to reference the renamed bidder code/module.
- Update module documentation examples to use
showheroesin ad unit configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/spec/modules/showheroesBidAdapter_spec.js | Switches test setup to the new module import and bidder code (showheroes). |
| modules/showheroesBidAdapter.md | Updates example configuration to use bidder: "showheroes". |
| modules/showheroesBidAdapter.js | Renames primary bidder code to showheroes and adds showheroes-bs to spec.aliases. |
Comments suppressed due to low confidence (2)
test/spec/modules/showheroesBidAdapter_spec.js:52
- PR description states
showheroes-bsremains supported for backwards compatibility, but the updated tests no longer cover that alias. Add a unit test that asserts the adapter still exposes/accepts the legacy code (e.g.,spec.aliasesincludesshowheroes-bs, and/or that the alias is registered in the bidderFactory/adapterManager if that’s how other adapter tests validate aliases).
modules/showheroesBidAdapter.md:31 - Examples were updated to use bidder code
showheroes, but the PR also keepsshowheroes-bsas a supported alias for backward compatibility. Add a short note near the example config indicating thatshowheroes-bsis still accepted as an alias (and optionally mentionshowheroesBsif it remains supported), so existing integrations know they don’t have to migrate immediately.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
EDIT: actually, for us it doesn't have to be the next major release. If you are fine with having a rename in the next PBJS release, let me know to merge this PR into #14643? |
Pull Request Test Coverage Report for Build 23554054909Details
💛 - Coveralls |
Type of change
Updated bidder adapter
Refactoring (no functional changes, no api changes)
Description of change
Rename
showheroes-bsto justshowheroes, but keep theshowheroes-bsas an alias for backwards compatibility.