GumGum Bid Adapter: Add Native Format Support#14683
GumGum Bid Adapter: Add Native Format Support#14683vasudevan-gg wants to merge 54 commits intoprebid:masterfrom
Conversation
Gumgum - ADTS-175 Support multiple GG params
…-support-jp-products ADJS-1165-prebid-adaptor-changes-to-support-jp-products
…exicon GumGum Bid Adapter - Added support for envelope key for id properties
ADJS-1646-update-userId-handling
GumGum Adapter: fix TDID extraction across all EID uids
…ect-from-prebid-to-ad-server GumGum Bid Adapter: send app site content object from prebid to ad server
…ect-from-prebid-to-ad-server updated access to channel and network objects
…10850-send-device-parameters-from-prebid-to-hbid-endpoint
…om-prebid-to-hbid-endpoint At 10850 send device parameters from prebid to hbid endpoint
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1931d68a0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (mediaTypes.native) { | ||
| sizes = [1, 1]; |
There was a problem hiding this comment.
This branch forces sizes to [1, 1] whenever mediaTypes.native exists, even if the request is actually using params.slot (in-slot banner path). The downstream slot logic expects banner size tuples and builds bf/max dimensions from sizes, so multi-format ad units (banner + native) with slot generate malformed slot size data and can lose in-slot demand.
Useful? React with 👍 / 👎.
5 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Add Native Format Support
Other information