Fix: Require explicit GVL vendor ID declaration for aliases#4683
Merged
bsardo merged 5 commits intoprebid:masterfrom Mar 5, 2026
Merged
Fix: Require explicit GVL vendor ID declaration for aliases#4683bsardo merged 5 commits intoprebid:masterfrom
bsardo merged 5 commits intoprebid:masterfrom
Conversation
… the GVL entry represents them
46660d2 to
32e8b30
Compare
9 tasks
SyntaxNode
reviewed
Feb 10, 2026
This was referenced Mar 3, 2026
hhhjort
approved these changes
Mar 3, 2026
Collaborator
hhhjort
left a comment
There was a problem hiding this comment.
Looks good, but I did not verify the GLV Vendor ID numbers.
karwaankit32
approved these changes
Mar 5, 2026
t-sormonte
pushed a commit
to Viously/prebid-server-go
that referenced
this pull request
Mar 20, 2026
anthonyrichir
pushed a commit
to proxistore/prebid-server
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #4463
This PR does the following:
Removes logic that allows aliases to inherit the GVL ID from its parent
Explicitly declares the same GVL ID for these aliases as its parent since it is clear the alias and parent are the same entity:
The following aliases are currently inheriting a GVL ID from the parent but IMO it is not clear that the alias should use the same GVL ID as the parent. Some of these though do appear to have their own GVL entries in the latest Global Vendor List:
This second group of adapters have been emailed at the maintainer address on file in their corresponding YAML file.