Skip to content

Add Pixfuture Adapter#4715

Open
pixfuture-media wants to merge 53 commits intoprebid:masterfrom
pixfuture-media:master
Open

Add Pixfuture Adapter#4715
pixfuture-media wants to merge 53 commits intoprebid:masterfrom
pixfuture-media:master

Conversation

@pixfuture-media
Copy link
Copy Markdown

The Pixfuture adapter has been updated to be compatible with v4.

pixfuture-media and others added 30 commits March 10, 2026 19:34
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
}
}

switch ext.Prebid.Type {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

}
}

switch ext.Prebid.Type {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

}
}

switch ext.Prebid.Type {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Fixing import in pixfuture.go
Fixed import in pixfuture_test.go
fixing import
fixing import in test go
@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 131920a

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:28:	MakeRequests		66.7%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:78:	MakeBids		92.3%
github.com/prebid/prebid-server/v4/adapters/pixfuture/pixfuture.go:137:	getMediaTypeForBid	69.2%
total:									(statements)		77.6%

@pixfuture-media
Copy link
Copy Markdown
Author

Hi @prebid-server-maintainers,

I have updated the Pixfuture adapter to be compatible with the v4 release. I have:
Updated all import paths in pixfuture.go and pixfuture_test.go from v3 to v4.
Resolved merge conflicts in adapter_builders.go and bidders.go caused by the version migration.
Verified that go test ./adapters/pixfuture/... passes locally.
The CI checks should now be green. Could you please take a look and let me know if any further changes are needed for the merge to master?

Thanks!
Vitali I.

@bsardo bsardo added the adapter label Mar 31, 2026
@pixfuture-media
Copy link
Copy Markdown
Author

Hi @prebid-server-maintainers,
Just checking in to see if there are any updates regarding our adapter.
Thanks,
Vitali I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants