Conversation
…t practices and improve clarity
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Co-authored-by: Sheridan C Rawlins <41922797+scr-oath@users.noreply.github.com>
Fix malformed JSON error handling in Pixfuture adapter
Fixed issue with macroses
Reordered by alphabet BidderPixfuture from the list of bidders.
fix order for BidderPixfuture,
| } | ||
| } | ||
|
|
||
| switch ext.Prebid.Type { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| } | ||
| } | ||
|
|
||
| switch ext.Prebid.Type { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| } | ||
| } | ||
|
|
||
| switch ext.Prebid.Type { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Fixing import in pixfuture.go
Fixed import in pixfuture_test.go
fixing import
fixing import in test go
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
|
Hi @prebid-server-maintainers, I have updated the Pixfuture adapter to be compatible with the v4 release. I have: Thanks! |
|
Hi @prebid-server-maintainers, |
The Pixfuture adapter has been updated to be compatible with v4.